Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] replace web-token/signature-pack with web-token/jwt-library #42954

Merged
merged 3 commits into from Mar 7, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Mar 4, 2024

Possible Pull Request for Issue #42952 .

Summary of Changes

replace abandoned composer packages

Testing Instructions

run composer install

Actual result BEFORE applying this Pull Request

warning
image

Expected result AFTER applying this Pull Request

no warning

Additional comments

Removed packages do not contain relevant files
image

only web-token/jwt-experimental ...
image

@richard67
Copy link
Member

I have tested this item ✅ successfully on e9bf761

The removed sub-dependencies consisted only of a readme file, the PHP files were already removed with the update from PR #42945 .

So we lose nothing with this PR here.

Unit tests, integration tests and system tests are successful, too.

However it needs to add some more deleted files and folders to script.php. I will make a follow-up PR for that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2024
@richard67
Copy link
Member

Follow-up PR for the deleted files and folders is PR #42955 .

@laoneo
Copy link
Member

laoneo commented Mar 5, 2024

I have tested this item ✅ successfully on e9bf761

No abandoned warnings


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 5, 2024
@bembelimen bembelimen merged commit b3560b4 into joomla:5.1-dev Mar 7, 2024
3 checks passed
@bembelimen
Copy link
Contributor

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2024
@heelc29 heelc29 deleted the 5.1/issue-42952 branch March 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants