Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5] contact error when deleting alias #42968

Merged
merged 3 commits into from Mar 13, 2024
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Mar 6, 2024

Pull Request for Issue #41713 .

Summary of Changes

add check for hits

Testing Instructions

Fill new contact under some category
Use "Save"
Use "Save as copy"
In this copy will be end of alias -2
Delete this end "-2" of alias
Save
Result: Save failed with the following error: Another Contact in this category has the same alias.
Delete all in alias line, to automaticaly generate new alias
Save
Result is empty alias(will not generate new one) and an ERROR: Save failed with the following error: Incorrect integer value: '

Actual result BEFORE applying this Pull Request

Result is empty alias(will not generate new one) and an ERROR: Save failed with the following error: Incorrect integer value: '

Expected result AFTER applying this Pull Request

no more error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@ceford
Copy link
Contributor

ceford commented Mar 11, 2024

I have tested this item ✅ successfully on 873e44d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42968.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 873e44d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42968.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42968.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2024
@bembelimen bembelimen merged commit 9ab22c2 into joomla:5.1-dev Mar 13, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 13, 2024
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Mar 14, 2024
@alikon alikon deleted the patch-21 branch March 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants