[5.1] Fix fatal error during Joomla update #42976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomdonation
commented
Mar 7, 2024
| @@ -573,8 +572,6 @@ public function deleteUnexistingFiles($dryRun = false, $suppressOutput = false) | |||
| 'folders_deleted' => [], | |||
| 'files_errors' => [], | |||
| 'folders_errors' => [], | |||
| 'folders_checked' => [], | |||
There was a problem hiding this comment.
For someone does code review, the two array elements definition here could be removed because it is immediately overwrite later at https://github.com/joomla/joomla-cms/blob/5.1-dev/administrator/components/com_admin/script.php#L2539-L2540
This was referenced Mar 7, 2024
|
Closing because the changes here are all included in other PR #42978 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
As of right now, update to Joomla 5.1 nightly build package will get fatal error. It is because the code for delete folders using
Path::cleanmethod which is not available for using. You can read the discussion at #42971 to understand more if neededAs the list of folders are provided by us, so it is clean and trusted, we can remove Path::clean call here. I also made some minor clean up to the code, too.
Testing Instructions
Actual result BEFORE applying this Pull Request
If you update your site to Joomla nightly build package, you will get fatal error
Expected result AFTER applying this Pull Request
No error updating to package generated by this PR.
Link to documentations
Please select: