-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Aliasing Filesystem classes for installation, updating script.php #42978
Conversation
Could you please also delete the two elements here https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L575-L576 as I did in in my original PR #42976 ? Thanks ! |
I have tested this item ✅ successfully on 5f35b5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978. |
@joomdonation Have you used Windows or a Linux as server? Would be good if we get another tester using what you haven't used. |
@brianteeman Does your thumbs down reaction on the description of this PR still apply, or is it obsolete after the recent changes? If obsolete: Please remove. If not obsolete: Would you like to comment on the reasons? Thanks in advance. |
@richard67 I tested using Windows. I also did a careful code review. |
@joomdonation Thanks. I did also a careful code review. PR is ok for me. Will see if I can find time to test on Linux. |
I have tested this item ✅ successfully on 5f35b5d I've also tested that updating from 5.1.0-beta 1 with the PR applied before the update works. Finally I've done a code review. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42978. |
Thx |
Pull Request for Issue #42971 .
Summary of Changes
With the refactoring of system calls to the framework filesystem package, I introduced a new error when updating since at the time when script.php is run, the framework class ist not there. This PR changes the namespace of the classes in the finalisation.php to reflect first the framework filesystem package and then to alias those classes for the CMS filesystem package. It also fixes the code in script.php to use the framework code consistently. That should hopefully fix the issue and be compatible pretty much regardless from where to where we upgrade.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed