Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] brotli compression #43171

Merged
merged 9 commits into from Mar 28, 2024
Merged

[5.1] brotli compression #43171

merged 9 commits into from Mar 28, 2024

Conversation

brianteeman
Copy link
Contributor

postinstall message for the new brotli compression option.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Mar 28, 2024
@brianteeman brianteeman mentioned this pull request Mar 28, 2024
4 tasks
@MacJoom
Copy link
Contributor

MacJoom commented Mar 28, 2024

Wow this was fast - thank you Brian!

@MacJoom
Copy link
Contributor

MacJoom commented Mar 28, 2024

we need it for 4.4 too - i can do it

@richard67
Copy link
Member

richard67 commented Mar 28, 2024

we need it for 4.4 too - i can do it

@MacJoom But then it still will need the update SQL from this PR here for the case when people update from 5.0.x. The INSERT IGNORE on MySQL/MariaDB and the ON CONFLICT DO NOTHING on PostgreSQL will make sure that the message will not be inserted again when it is already there when people update from 4.4.4 to 5.1.

Your 4.4-dev PR will need new update SQL scripts "4.4.4-2024-03-28.sql" with the same content as the script here (except of the version number in the inserted data).

brianteeman and others added 3 commits March 28, 2024 11:38
…0-2024-03-28.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…0-2024-03-28.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67
Copy link
Member

I've already tested with success on MySQL. With PostgreSQL the update fails for reasons not related to this PR here, see #43175 . But that delays my test on PostgreSQL for this PR here a bit.

@richard67
Copy link
Member

I have tested this item ✅ successfully on ea4ca47

I've tested updating to the patched package on both MySQL and PostgreSQL. In both cases it worked, and the postinstall message was added.

For the test with PostgreSQL I had to create a patched package which includes the fix from this PR here as well as the fix from #43175 . Other testers with PostgreSQL can find that package here: https://test5.richard-fath.de/Joomla_5.1.0-beta3-dev+pr.43171-Development-Update_Package__fixed.zip


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.

@richard67
Copy link
Member

I've restored my test result in the tracker since the commits after that were just a branch update with conflicts resolution. I've carefully reviewed the result.

@MacJoom
Copy link
Contributor

MacJoom commented Mar 28, 2024

I have tested this item ✅ successfully on 605e52a

Tested on a server with psql and nginx


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2024
@LadySolveig LadySolveig merged commit d179b09 into joomla:5.1-dev Mar 28, 2024
1 check passed
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and for support @richard67 and @MacJoom

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants