New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] brotli compression #43171
[5.1] brotli compression #43171
Conversation
Wow this was fast - thank you Brian! |
administrator/components/com_admin/sql/updates/postgresql/5.1.0-2024-03-28.sql
Outdated
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/5.1.0-2024-03-28.sql
Outdated
Show resolved
Hide resolved
we need it for 4.4 too - i can do it |
@MacJoom But then it still will need the update SQL from this PR here for the case when people update from 5.0.x. The Your 4.4-dev PR will need new update SQL scripts "4.4.4-2024-03-28.sql" with the same content as the script here (except of the version number in the inserted data). |
…0-2024-03-28.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…0-2024-03-28.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
I've already tested with success on MySQL. With PostgreSQL the update fails for reasons not related to this PR here, see #43175 . But that delays my test on PostgreSQL for this PR here a bit. |
I have tested this item ✅ successfully on ea4ca47 For the test with PostgreSQL I had to create a patched package which includes the fix from this PR here as well as the fix from #43175 . Other testers with PostgreSQL can find that package here: https://test5.richard-fath.de/Joomla_5.1.0-beta3-dev+pr.43171-Development-Update_Package__fixed.zip This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171. |
administrator/components/com_admin/postinstall/htaccessbrotli.php
Outdated
Show resolved
Hide resolved
I've restored my test result in the tracker since the commits after that were just a branch update with conflicts resolution. I've carefully reviewed the result. |
I have tested this item ✅ successfully on 605e52a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171. |
Thank you @brianteeman and for support @richard67 and @MacJoom |
postinstall message for the new brotli compression option.