Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Postinstallation-Message htaccess.txt brotli change #43173

Merged

Conversation

MacJoom
Copy link
Contributor

@MacJoom MacJoom commented Mar 28, 2024

Postinstallation-Message for Brotli compression bug #43055

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels Mar 28, 2024
Co-authored-by: Quy <quy@nomonkeybiz.com>
@richard67
Copy link
Member

I have tested this item ✅ successfully on e3200de

I've tested updating to the patched package on both MySQL and PostgreSQL. In both cases it worked, and the postinstall message was added.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43173.

@brianteeman
Copy link
Contributor

not sure what will happen when someone who has updated to 4.4.4 then goes to 5.1 - worse case i think is that they will see the message twice

@richard67
Copy link
Member

richard67 commented Mar 28, 2024

not sure what will happen when someone who has updated to 4.4.4 then goes to 5.1 - worse case i think is that they will see the message twice

@brianteeman Check my comments in your PR. The message will not be duplicated as we have the INSERT IGNORE/ON CONFLICT DO NOTHING.

@brianteeman
Copy link
Contributor

which is why I said "not sure" ;)

@laoneo laoneo merged commit bdb23b8 into joomla:4.4-dev Mar 28, 2024
3 of 4 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants