[5.1] Delete 4.4.4-2024-03-28.sql update SQL scripts and update deleted files list in script.php #43187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) deletes the update SQL scripts "4.4.4-2024-03-28.sql" from the sources and adds these files to the list of files to be deleted on update in file
administrator/components/com_admin/script.phpso they will be deleted when updating from 4.4 to 5.1.In general we do not require to be at the latest 4.4.x version for updating to 5.1. The targetplatform values of the 5.0.3 version on https://update.joomla.org/core/list.xml and https://update.joomla.org/core/j4/default.xml allows updating to 5.0.3 from any 4.4.x version, and I assume it will be like that for 5.1.
So theoretically we should keep any 4.4.x update SQL scripts with x > 0 in 5.1 because it could be that people update from a 4.4.0.
Practically that is not necessary as we have to provide another pair of SQL update scripts in 5.1 for people updating from 5.0.x to make the same changes for these cases if not already done. In this case here these are the scripts "5.1.0-2024-03-28.sql". They need a fix for the "if not already done" part, see my other PR #43182 , which hopefully will be accepted.
So it is safe to delete the "4.4.4-2024-03-28.sql" here, and I think it makes sense to do that as that is how we proceeded in past with update SQL scripts from the previous major version.
Testing Instructions
Code review.
Or if you want to make a real test, update the latest 4.4 nightly build to the latest 5.1 nightly build to get the actual result, and update the latest 4.4 nightly build to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The file mentioned above is still present after updating from the latest 4.4 nightly build, and so it will when updating from 4.4.4.
Expected result AFTER applying this Pull Request
The file mentioned above has been deleted with the update from the latest 4.4 nightly build, and so it will when updating from 4.4.4.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed