[4.4] Backendmenu: Fixing export of additionla features for menu items #43188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #41268 .
Summary of Changes
While looking at #41268 I noticed that the export of backend menus currently is not properly exporting the attributes for the quicktask, dashboard and ajax-badge feature. This PR fixes that.
Please note that the export also currently does not properly export the tree structure of the menu. This is fixed in #43178.
Please also note, that the backend menu items don't properly support the quicktask, dashboard and ajax badge features in the menu item configuration yet. This is something that needs to be fixed in another PR.
Testing Instructions
Actual result BEFORE applying this Pull Request
There is no
dashboard="",quicktask="","ajax-badge=""or icon, title and permission attribute for the quicktask in the XML. The preset and the export differ wildly.Expected result AFTER applying this Pull Request
There are attributes for the above mentioned features and the preset and export are a lot more similar.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed