Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use update channel the correct way #43190

Merged
merged 21 commits into from Apr 2, 2024

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Apr 1, 2024

Alternatives for #43184

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on e9e03f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43190.

@richard67
Copy link
Member

@bembelimen It seems this PR breaks the unit tests for the constraint checker.

@laoneo
Copy link
Member

laoneo commented Apr 2, 2024

Why did you revert the final statement? Sounds logic to me instead of the long description that this class is internal only.

@bembelimen
Copy link
Contributor Author

I'm not keen to rewrite and fix all the tests, when I declare them as final (plus, I don't like to close classes that way). Feel free to look into it, but I don't plan to do it before the RC.

@LadySolveig LadySolveig merged commit 5bcc433 into joomla:5.1-dev Apr 2, 2024
2 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants