New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Use update channel the correct way #43190
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
I have tested this item ✅ successfully on e9e03f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43190. |
@bembelimen It seems this PR breaks the unit tests for the constraint checker. |
Why did you revert the final statement? Sounds logic to me instead of the long description that this class is internal only. |
I'm not keen to rewrite and fix all the tests, when I declare them as final (plus, I don't like to close classes that way). Feel free to look into it, but I don't plan to do it before the RC. |
Thank you! |
Alternatives for #43184