-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Adminmenu: Toggle for duplicate menus #43192
Conversation
If you do this as per the original report by duplicating the existing module then you break accessibility as you have multiple things using the same id but thats off topic |
This may well fix the bug in 4.4 but the js was rewritten for j5.1 (#42784) so it will not be able to be upmerged. My recommendation would be to close this pr for 4.4 and redo it for 5.1 |
I have tested this item ✅ successfully on ed76cd4 PHP 8.2.17, MySQL 8.0.36 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192. |
I have tested this item ✅ successfully on ed76cd4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192. |
@Hackwar As @brianteeman correctly mentioned in his previous comment, this fix can't be merged up into 5.1-dev as it is because in 5.1-dev the js was refactored. It would need to make the same changes as here but in these 2 lines:
Could you make a PR for 5.1-dev, too? It needs both, I think, this one here for 4.4-dev and another one for 5.1-dev. |
@Hackwar As I did not get any response to my comment, I've decided to create the 5.1-dev PR myself. Thanks for the fix here. PR for 5.1-dev is #43308 . To all testers: Could you also test my PR #43308 for 5.1? Thanks in advance. |
Tested #43308 for J5.1.x - thanks @richard67. |
Thank you! |
Pull Request for Issue #32934 .
Summary of Changes
When the backend menu is duplicated, the JS to toggle the sidebar doesn't work for the second menu.
Testing Instructions
Actual result BEFORE applying this Pull Request
The sidebar stays closed.
Expected result AFTER applying this Pull Request
The sidebar opens, like for the menu entries in the first menu module.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed