Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix calendar value #43234

Open
wants to merge 1 commit into
base: 5.1-dev
Choose a base branch
from
Open

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 8, 2024

Pull Request for #42709 (comment) .

Summary of Changes

The calendar field was doing extra changes for the value, which is bypassing data[value]

Testing Instructions

Please follow #42709 (comment)

Or edit any existing article date. In this case all should work as before.

Actual result BEFORE applying this Pull Request

Wrong date

Expected result AFTER applying this Pull Request

Correct date

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@svenbluege
Copy link
Contributor

Tested with Joomla 5.1. RC2: this change works and brings back the functionality in non-english backoffice-languages.

@richard67
Copy link
Member

@svenbluege Could you go to the issue tracker and mark your test result so it's properly counted? Each pull request needs 2 human tests, and yours would be one. For this, go to https://issues.joomla.org/tracker/joomla-cms/43234 , use the blue "Test this" button at the top left corner, select your test result (success) and finally submit. Thanks in advance.

@svenbluege
Copy link
Contributor

I have tested this item ✅ successfully on 8b94a61

Tested successful with a German backoffice + a component which renders the label and then the input of the calendar field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43234.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8b94a61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43234.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.1-dev RTC This Pull Request is Ready To Commit
Projects
None yet
5 participants