Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom css #43392

Open
wants to merge 11 commits into
base: 5.2-dev
Choose a base branch
from
Open

add custom css #43392

wants to merge 11 commits into from

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented Apr 27, 2024

Pull Request for Issue #41205 .

Summary of Changes

Checked if class is set and added it to the fields

Testing Instructions

copied from the issue

$options=array();
$o = new stdClass();
$o->value = 1;
$o->text = 'option 1';
$options[] = $o;

$attribs=array();
$attribs['class'] = 'MyCLass'
HTMLHelper::_('select.radiolist', $options, 'fieldname', $attribs);

Actual result BEFORE applying this Pull Request

<div class="controls">
  <div class="form-check form-check-inline">
    <input type="radio" class="form-check-input"  name="fieldname" id="fieldname1" value="1" class="MyCLass">
    <label for="fieldname1" class="form-check-label" id="fieldname1-lbl">option 1</label>
  </div>
</div>

class attribute is duplicated

Expected result AFTER applying this Pull Request

<div class="controls">
  <div class="form-check form-check-inline">
    <input type="radio" class="form-check-input MyCLass"  name="fieldname" id="fieldname1" value="1">
    <label for="fieldname1" class="form-check-label" id="fieldname1-lbl">option 1</label>
  </div>
</div>

Both the form-check-input and MyCLass should be merged in one class attribute

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

fix 41205
rdeutz and others added 2 commits April 28, 2024 16:25
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@rdeutz
Copy link
Contributor Author

rdeutz commented Apr 28, 2024

Thanks @richard67

@Quy
Copy link
Contributor

Quy commented Apr 29, 2024

I have tested this item ✅ successfully on 8932488


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Apr 30, 2024

I have tested this item ✅ successfully on 8932488


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

@alikon
Copy link
Contributor

alikon commented Apr 30, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43392.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 30, 2024
@rdeutz
Copy link
Contributor Author

rdeutz commented May 2, 2024

just for the record, I used this PR to pin the mysql service in our testing to 8.3.0 because it seems we have a problem with 8.4 and the integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants