Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit to 10 #43393

Open
wants to merge 3 commits into
base: 5.2-dev
Choose a base branch
from
Open

Update PHPUnit to 10 #43393

wants to merge 3 commits into from

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented Apr 27, 2024

Pull Request for Issue #42528 .

Summary of Changes

Update PHPUnit to the next major version because the current one we are using is outdated

Testing Instructions

Test/Merge after #43381

Unit test should work as before.

@richard67
Copy link
Member

@rdeutz It seems you are updating a lot of composer dependencies, see the lock file. Can it be that you have just run a composer update instead of a composer update phpunit/phpunit?

@brianteeman
Copy link
Contributor

@richard67 try that and you will see why

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4f5f61c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43393.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4f5f61c

@brianteeman You have noticed that both appveyor and drone are failing due to failing unit tests?

@rdeutz If that is expected because it needs the other PR, then your testing instructions should make that more clear.

@brianteeman
Copy link
Contributor

@richard67 not sure what happened but when you replied to my comment you actually edited it. So it looks like I have said what you said. I have deleted it. and paste below

The composer lock updates are correct and if you try to do a composer update phpunit (as I said) then you will see why

Tests failing does not necessarily mean that the PR is wrong. It can also mean that the tests are wrong. We know that there are multiple tests that are either wrong or flakey.

I am well aware that these are failing unit tests which are failing. Thats what I was referring to.


As you can see now from Roberts ammended update the original update was correct. You just need to try it for yourself and you will see that you cannot just update phpunit without also updating a large batch of dependencies.

@richard67
Copy link
Member

not sure what happened but when you replied to my comment you actually edited it.

@brianteeman No idea what happened either, but it was not by purpose.

As you can see now from Roberts ammended update the original update was correct.

I know it needs to update a bunch of them, but in the first attempt there were definitely some included which are no dependencies of PHP unit. Now after the recent 2 commits it seems to be right.

@rdeutz
Copy link
Contributor Author

rdeutz commented Apr 29, 2024

@rdeutz If that is expected because it needs the other PR, then your testing instructions should make that more clear.

updated

one fail is expected when #43381 is not merged the other ones not

re-did the composer update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants