Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Joomla Update : extensions check never ends (from #43226) #43410

Merged
merged 92 commits into from May 20, 2024

Conversation

conseilgouz
Copy link
Contributor

Original PR #43226 closed by mistake

Summary of Changes
Fix PHP 8.2 deprecated notices during Extensions check while performing Joomla 5.1.0 update

Testing Instructions
Joomla 5.0.3, PHP 8.2 or higher, enable Error reporting to default.
In Joomla Update configuration, set "Potentially incompatible extensions checkbox" to "Show".
Install any non core extension

Update Joomla to 5.1.0-RC shows the Pre-Update Screen.

Actual result BEFORE applying this Pull Request
Extensions check never ends, an error appears in explorer console : uncaught syntaxError..

Expected result AFTER applying this Pull Request
Extensions check works fine

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

conseilgouz and others added 30 commits March 1, 2024 17:39
Missing item name
….php

Co-authored-by: Brian Teeman <brian@teeman.net>
….php

Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
…g.php

Co-authored-by: Brian Teeman <brian@teeman.net>
remove tabs
add new lines at end of files
@laoneo
Copy link
Member

laoneo commented May 1, 2024

Looks good

@bembelimen bembelimen added this to the Joomla! 5.1.1 milestone May 11, 2024
@bembelimen bembelimen merged commit 4cf154d into joomla:5.1-dev May 20, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PHP 8.x PHP 8.x deprecated issues PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants