Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imp] Adding method to trim normal, non-breaking and multibyte spaces #4492

Merged
merged 2 commits into from Oct 10, 2014

Conversation

infograf768
Copy link
Member

See discussion #4489

the code to use would be:

JFilterInput::getInstance()->clean((string) $mystring, 'trim')

@joomdonation
Copy link
Contributor

Maybe you can give some sample strings (which contains non-breaking spaces and double byte whitespaces) so that we can use to test this method ?

@infograf768
Copy link
Member Author

Here is a string:

nonbreaking nonbreaking
multi multi

The spaces are in the middle. Just pick them and add first and last

@joomdonation
Copy link
Contributor

@test: OK. The method successfully remove normal, non-breaking and multibyte spaces before and end of a string.

infograf768 added a commit that referenced this pull request Oct 10, 2014
[imp] Adding method to trim normal, non-breaking and multibyte spaces
@infograf768 infograf768 merged commit ef49dec into joomla:staging Oct 10, 2014
@pe7er
Copy link
Contributor

pe7er commented Oct 10, 2014

I tested on staging (Joomla! 3.3.7-dev) using patch tester but issue has not been solved.

A username like " 123", that's [space] + 123 is still accepted.
and in User Manager when you edit the user details you can see the space in the form field.

@joomdonation
Copy link
Contributor

@pe7er : You need to apply both this full request and #4489 before testing. Could you please try again?

@pe7er
Copy link
Contributor

pe7er commented Oct 10, 2014

Sorry, I did not understand that. I'll test with #4489 patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants