Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#27446] Fix: can not dump multiple objects contained in the session #49

Closed
wants to merge 9 commits into from

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Dec 20, 2011

When the session contains multiple objects, only the first object can be "unfolded" while the other(s) are displayed but can not be "opened" caused by a wrong id.

Test:

<?php
$foo = new stdClass;
$foo->bar = 'baz';
$_SESSION['foo'] = $foo;

joomlacode.org tracker: #27446

@realityking
Copy link
Contributor

9 commits for a one line change? Whoever commits this, please don't just merge, apply it manually. Thanks. :)

@elkuku
Copy link
Contributor Author

elkuku commented Dec 21, 2011

Well, I realized after submitting the pull that the branch contains also previous work done to the debug plugin. But I suppose it will be applied as a patch, so history is lost anyway ;)
But in fact it is all related to the debug plugin..

@elkuku
Copy link
Contributor Author

elkuku commented Feb 14, 2012

Just a little bumper after two month... is there any reason not to fix this ? I hope it is not because I mentioned Nooku....

@realityking
Copy link
Contributor

Maybe you could explain a bit what your patch does? I don't understand it.

@elkuku
Copy link
Contributor Author

elkuku commented Feb 15, 2012

It is just a simple mistake, done by a guy with poor Javascript abilities (me).

Please just try the three lines of code I posted above in a place where they get executed, turn on debug and have a look at the debug output. You will see the entry in the session tab, but it can not be "unfolded" - apply the patch and F5.

If you can improve the ugly Javascript (without using mootools) - that would bee cool.

Hope this helps :)

@elkuku
Copy link
Contributor Author

elkuku commented Jun 25, 2012

@elkuku elkuku closed this Jun 25, 2012
wilsonge added a commit that referenced this pull request Apr 7, 2016
ciar4n pushed a commit to ciar4n/joomla-cms that referenced this pull request Mar 19, 2017
@elkuku elkuku deleted the debug-plugin-2 branch April 19, 2017 05:04
wilsonge pushed a commit that referenced this pull request Jun 4, 2017
* Codestyle

* indent

* order

* oops

* changes requested by @andrepereiradasilva

* cs

* changes requested by @wojsmol

* Update mod_logged.xml (#43)

* Update templateDetails.xml (#45)

i need to fix my ide!!

* Update mod_popular.xml (#44)

* Update templateDetails.xml (#57)

* Update mod_version.xml (#56)

* Update mod_toolbar.xml (#55)

* Update mod_title.xml (#54)

* Update mod_submenu.xml (#53)

* Update mod_status.xml (#52)

* Update mod_stats_admin.xml (#51)

* Update mod_quickicon.xml (#50)

* Update mod_menu.xml (#49)

* Update mod_login.xml (#48)

* Update mod_latest.xml (#47)

* Update mod_feed.xml (#46)
laoneo pushed a commit to Digital-Peak/joomla-cms that referenced this pull request May 14, 2018
…p/crop.js

Transform plg_media-action-crop/crop.js to ES6
anuragteapot added a commit to anuragteapot/joomla-cms that referenced this pull request Aug 26, 2018
hans2103 pushed a commit to hans2103/joomla-cms that referenced this pull request Sep 7, 2020
…item-with-link

Metismenu - Fix dropdown toggle for parent menu items with links
HLeithner pushed a commit that referenced this pull request Jun 1, 2021
)

* Apply PHPCS to the build tools and remove unused md5/sha1 hashes

* phpcs (#49)

* phpcs

* revert to suitable lang level

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
ditsuke added a commit to ditsuke/joomla-cms that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants