Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding choice to only resize TinyMCE vertically #5680

Merged
merged 2 commits into from
Jan 13, 2015

Conversation

infograf768
Copy link
Member

See http://issues.joomla.org/tracker/joomla-cms/5660

This PR re-implements the choice we had in the TinyMCE 3.5 series (in Joomla 2.5) to resize the editor only vertically instead of both directions.
It could not be implemented when we switched to Tiny 4 because it was buggy.

To test switch both the resizing parameters in Tiny advanced parameters.

@uthorat
Copy link

uthorat commented Jan 12, 2015

@infograf768 Hi I tested this patch . Great Work !!!
For article manager is done :)
Unfortunately something is missing, you should check the
Users -> mass mail for users.
Still editor is getting messed up with the other option.

Adding an screenshot
mass mail

Warm Regards,
Umesh Thorat

@richard67
Copy link
Member

@test Success.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5680.

@brianteeman
Copy link
Contributor

@test all good - also tested with custom html module.

@uthorat The issue with the mass mail is different as that is not the TinyMCE editor please can you create a new issue for that


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5680.

@uthorat
Copy link

uthorat commented Jan 12, 2015

Okay thanx to inform :)
Happy that work with you guyss :)
Creating an new issue
On 12 Jan 2015 23:49, "Brian Teeman" notifications@github.com wrote:

@test https://github.com/test all good - also tested with custom html
module.

@uthorat https://github.com/uthorat The issue with the mass mail is
different as that is not the TinyMCE editor please can you create a new

issue for that

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/5680
http://issues.joomla.org/tracker/joomla-cms/5680.


Reply to this email directly or view it on GitHub
#5680 (comment).

@infograf768 infograf768 added this to the Joomla! 3.4.0 milestone Jan 13, 2015
infograf768 added a commit that referenced this pull request Jan 13, 2015
Adding choice to only resize TinyMCE vertically
@infograf768 infograf768 merged commit f2e1c95 into joomla:staging Jan 13, 2015
@infograf768
Copy link
Member Author

Thanks for testing. Merged.

@infograf768 infograf768 deleted the tiny_horizontal branch January 13, 2015 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants