Fix #5955: Search Engine Friendly URLs is not friendly to TOS article

[joomdonation]

Please see #5955 to understand the issue.

To test this PR:

1. Enable "User - Profile" plugin and assign an article with TOS
2. Set "Search Engine Friendly URLs" to "Yes" at global configuration
3. Check and make sure When user wants create a account and click "Terms of Service:" link, it will show
   a modal box with TOS article.

[zero-24]

@joomdonation are you sure by removing this line?

How we handle it ($link) if no $tosarticle is set?

[joomdonation]

Yes. That line of code is not used at all. In that block of code, if the article is not selected, it will go to the else block:

$link = $text;

Infact, when no article is selected, this tos field will be removed from the form https://github.com/joomla/joomla-cms/blob/staging/plugins/user/profile/profile.php#L265

So the code is correct.

[coolcat-creations]

Tested successfully with SEF on and with URL rewriting on.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5968.}

[zero-24]

RTC based on the lastes tests Thanks.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5968.}