Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mobile admin menu #6298

Merged
merged 1 commit into from Mar 8, 2015
Merged

Fixed mobile admin menu #6298

merged 1 commit into from Mar 8, 2015

Conversation

ghost
Copy link

@ghost ghost commented Mar 4, 2015

This fixes the fixed height issue for the admin menu on narrow screens.

See for more info:
Github: #6190
JIssues: http://issues.joomla.org/tracker/joomla-cms/6190

@ghost ghost mentioned this pull request Mar 4, 2015
@C-Lodder
Copy link
Member

C-Lodder commented Mar 4, 2015

Yup, this appears to work on:

  • Android (Chrome)
  • Firefox (Desktop - responsive mode)

However I would remove the class .collapse from the toggle button as it reduces the height of it.

screeny

@ghost
Copy link
Author

ghost commented Mar 4, 2015

The class on the toggle button is not collapse but collapsed (with a d)

@C-Lodder
Copy link
Member

C-Lodder commented Mar 4, 2015

@nonumber - Ahh my bad.

@n9iels
Copy link
Contributor

n9iels commented Mar 4, 2015

@test: works fine for me, thanks! I noticed this bug this afternoon, glad you fixed it :-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6298.

@ghost
Copy link
Author

ghost commented Mar 7, 2015

Thanks for testing!

@ghost ghost changed the title fixed mobile menu yet again Fixed mobile admin menu Mar 8, 2015
@cyrezdev
Copy link
Contributor

cyrezdev commented Mar 8, 2015

@test success! (both small sized window and iPhone)

The menu on narrow screens is now working back as it was working on 3.3.6! Thank you, didn't notice this bug in 3.4.0, and i'm happy this one is fixed before i'm away for a week-end, with only my iPhone to manage! ;-)

Thank you! 👍

@zero-24
Copy link
Contributor

zero-24 commented Mar 8, 2015

RTC based on testing. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6298.

wilsonge added a commit that referenced this pull request Mar 8, 2015
@wilsonge wilsonge merged commit bcc00ed into joomla:staging Mar 8, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.1 milestone Mar 8, 2015
@ghost ghost deleted the patch-1 branch March 8, 2015 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants