Added Article count (published, unpublished, trashed) to Category Man… #6916

pe7er · 2015-05-10T11:46:38Z

…ager for com_content component.

In Joomla 1.5 the Category Manager showed the number of published, unpublished and trashed articles per category. Since than the Category Manager has been improved to be more generic and is used in all core components. You can even use it in your own component. However, because it's more generic, it does not show the counter anymore.

This PR adds the number of published, unpublished and trashed articles in the Category Manager for the Articles only.

Testing instruction

Test before Patch

The Category Manager shows the Categories but does not show number of articles in those categories.
(in back-end: Content > Category Manager)

Test after applying Patch

Install the patch via Patch Tester Component. In Article Manager, unpublish a couple of articles & trash a couple of articles. Go to Category Manager (Content > Category Manager). The Category Manager should show 3 new columns with the numbers of published, unpublished and trashed articles per category.

Test the Category Manager with other core components

The Category Manager should not show those columns & numbers for other components. Eg. check the "Category Manager: Contacts" (Components > Contacts > Categories)

…ager for com_content component.

brianteeman · 2015-05-10T11:53:53Z

Doesnt this require an update for the hathor template overrided

On 10 May 2015 at 12:46, Peter Martin notifications@github.com wrote:

…ager for com_content component.

In Joomla 1.5 the Category Manager showed the number of published,
unpublished and trashed articles per category. Since than the Category
Manager has been improved to be more generic and is used in all core
components. You can even use it in your own component. However, because
it's more generic, it does not show the counter anymore.

This PR adds the number of published, unpublished and trashed articles in
the Category Manager for the Articles only.

[Testing instruction will follow soon...]

You can view, comment on, or merge this pull request online at:

#6916
Commit Summary

Added Article count (published, unpublished, trashed) to Category
Manager for com_content component.

File Changes

M administrator/components/com_categories/models/categories.php
https://github.com/joomla/joomla-cms/pull/6916/files#diff-0 (16)

M
administrator/components/com_categories/views/categories/tmpl/default.php
https://github.com/joomla/joomla-cms/pull/6916/files#diff-1 (26)

M administrator/language/en-GB/en-GB.com_categories.ini
https://github.com/joomla/joomla-cms/pull/6916/files#diff-2 (5)

Patch Links:

https://github.com/joomla/joomla-cms/pull/6916.patch

https://github.com/joomla/joomla-cms/pull/6916.diff

—
Reply to this email directly or view it on GitHub
#6916.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

pe7er · 2015-05-10T12:12:11Z

Yes, thanks, you are right about that.

Could you please test this PR with the default Isis template?

If there are no errors then I will write and add a fix for the Hathor template override.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

zero-24 · 2015-05-10T12:23:00Z

@pe7er can you try to fix the Travis errors?

FILE: ...oomla-cms/administrator/components/com_categories/models/categories.php
--------------------------------------------------------------------------------
FOUND 12 ERROR(S) AFFECTING 12 LINE(S)
--------------------------------------------------------------------------------
 279 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 280 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 281 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 282 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 283 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 284 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 286 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 287 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 289 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 290 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 292 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 293 | ERROR | Tabs must be used to indent lines; spaces are not allowed
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

and agline the new code into the views? If you would i can do a PR against yours 😄

pe7er · 2015-05-10T12:26:33Z

Oops... Thanks, I'll do that later...

(reminder to myself: reconfigure PHPStorm to use real tabs)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

zero-24 · 2015-05-10T12:26:40Z

@test @pe7er can you also center the values else we get something like this:

brianteeman · 2015-05-10T12:28:50Z

I would prefer them all to be left aligned. BUT whatever you do it should
be consistent with the th and the td

On 10 May 2015 at 13:26, zero-24 notifications@github.com wrote:

@test https://github.com/test @pe7er https://github.com/pe7er can you
also center the values else we get something like this:
[image: center_categors]
https://cloud.githubusercontent.com/assets/2596554/7554255/911c23ae-f720-11e4-8ff9-3b0c27ce342e.PNG

—
Reply to this email directly or view it on GitHub
#6916 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

zero-24 · 2015-05-10T12:29:25Z

Just one bug more on mobile it looks bad as we have the icons but not the values see:

brianteeman · 2015-05-10T13:14:03Z

Not sure I understand why

You are only doing this for com_content
You are only showing 3 of the 4 states

On 10 May 2015 at 13:29, zero-24 notifications@github.com wrote:

Just one bug more on mobile it looks bad as we have the icons but not the
values see:
[image: counts_on_phone]
https://cloud.githubusercontent.com/assets/2596554/7554265/def36416-f720-11e4-8764-cef34439bed3.PNG

—
Reply to this email directly or view it on GitHub
#6916 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

pe7er · 2015-05-10T13:59:10Z

Thank you both for all feedback!

You are only doing this for com_content

com_content is the most important component in the CMS.
It's possible to do it for all core components but you'll need a lot of extra code & checks
The Category Manager component can be used in 3rd party extensions as well, but there you cannot add these fields.
Someone here at Joomladay France asked me about it. He used this feature in the past in J1.5 a lot and missed it in 3.x.

You are only showing 3 of the 4 states

I did not want to show too much information and IMHO "Archived" is less important than the other 3 states.
The Menu Manager shows these 3 states too. Menus > Menu Manager.
_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

brianteeman · 2015-05-10T14:02:02Z

The Category Manager component can be used in 3rd party extensions as
well, but there you cannot add these fields.

Really?
On 10 May 2015 14:59, "Peter Martin" notifications@github.com wrote:

Thank you both for all feedback!

You are only doing this for com_content

com_content is the most important component in the CMS.

It's possible to do it for all core components but you'll need a lot
of extra code & checks

The Category Manager component can be used in 3rd party extensions
as well, but there you cannot add these fields.

Someone here at Joomladay France asked me about it. He used this
feature in the past in J1.5 a lot and missed it in 3.x.

You are only showing 3 of the 4 states

I did not want to show too much information and IMHO "Archived" is
less important than the other 3 states.

- The Menu Manager shows these 3 states too. Menus > Menu Manager.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/6916
http://issues.joomla.org/tracker/joomla-cms/6916.

—
Reply to this email directly or view it on GitHub
#6916 (comment).

Bakual · 2015-05-10T14:08:06Z

I don't like com_content specific checks in com_categories.
It should instead be done in a way which works for other extensions as well.

There is already a category helper which defines the respective table and state field for a component. Maybe that could be used to get the counts?

Bakual · 2015-05-10T14:11:17Z

Also you may want to check the space used for that information. There is a lengthy title for only a number, which in the end cuts down space for the (much more important) title. Maybe just the icon as title would be sufficient? Or some UI guy has a clever idea?

pe7er · 2015-05-10T14:23:05Z

The Category Manager component can be used in 3rd party extensions as
well, but there you cannot add these fields.

Really?

Yeah, change
/administrator/index.php?option=com_categories&extension=com_content
to
/administrator/index.php?option=com_categories&extension=com_messages
to see that you can trigger the Messaging component with "Category Manager". You can create categories for your Messages, but as the Message items do not have a catid, the categories will be useless for the messages.

This feature is very nice and can be used in your own custom components!!!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

dgrammatiko · 2015-05-10T14:38:56Z

I like this change. About a possible lengthy title: One solution could be, the that holds the title to have two lines so the information Alias span to a new line. Also word-wrap: break-word; could be handy here.
As mentioned before mobile hidden and placement of the td’s needs some work.
But 💯 for the idea!

pe7er · 2015-05-10T15:09:41Z

I'm working on all the feedback and will even implement some extra functionality + better layout very soon...

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

brianteeman · 2015-05-10T16:58:03Z

to see that you can trigger the Messaging component with "Category Manager". You can create categories for your Messages, but as the Message items do not have a catid, the categories will be useless for the messages.

Actually you cant create them as there is no ability ti save the category ;)

ghost · 2015-05-10T16:58:08Z

I did not want to show too much information and IMHO "Archived" is less important than the other 3 states.

Sorry, why? Just because you don't use this status? ;-)

The Menu Manager shows these 3 states too. Menus > Menu Manager.

Yes, but just because you cannot archive menu items.

…ry Manager

pe7er · 2015-05-10T17:17:19Z

I've made some changes in the Category Manager:
now the counted Articles per Category have different colors & are hyperlinked to the Article Manager,
and the right filters are set: Category (+ level) + state.

New version:

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

dgrammatiko · 2015-05-10T17:32:35Z

How about

change line 159 to p
add a class alias before class small
add css to alias margin: 2px 0 -7px;

Alias can be as lengthy as the title and for languages like German with very long words this can be a problem.
This proposal needs review because if it gets accepted we have to adjust all the views in isis

pe7er · 2015-05-10T17:38:34Z

Ok, makes sense about "Archive.
I have:

removed the column labels (now only icons)
changed the column width from 10% to 5%
added an "Archived" article view + hyperlink to Article Manager with correct filters.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

pe7er · 2015-05-10T17:43:19Z

@dgt41 Thanks for your feedback.

I agree about the aliases. However, in your screenshot there are no multiple level sub categories. I've to check how it looks to put the alias on the next line with the sub categories.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

pe7er · 2015-05-10T17:45:51Z

@Bakual I agree with you that it's not so nice to have com_content specific checks in com_categories.

If (3rd party) components would be able to add their own count using a helper file that works together with com_categories, then it would be much better...

I'll check out your suggestion some other time soon.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

pe7er · 2015-05-10T17:55:32Z

Mhh. sorry Travis... my code failed :-(

I'll correct it soon, but some other time.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

pe7er · 2015-05-14T09:36:28Z

I've fixed the undefined constant notice + footer td colspan.
Thanks for spotting those @losedk !

pe7er · 2015-05-14T09:57:19Z

The query

 SELECT `catid`, `state`, count(1) FROM `d1y5s_content` GROUP BY `catid`, `state`

works excellent, @Bakual! It gives all catids + state (or use published if your table uses that) + number of items.

We need to display the numbers in the Categories View. It can be accomplished with some lookup in an array/object for each td field (and if not present, display a 0).

As I need the numbers (including 0) in the records of the categories anyway, I think that my SQL is easier. E.g. if a table (eg com_content) does not have any Archived items, the column with "0" values will be displayed.

However, if your SQL improves the performance (and lookup in the object is faster) then I think we should change that SQL to your suggestion.

…space after comma in function call for Travis

pe7er · 2015-05-14T11:12:26Z

Ok, thank you all for all feedback!

I have got rid of the extra helper file and moved the SQL to the existing helper file of the component that uses the Category Manager to list its Categories (Thanks @roland-d for your help!)

I've also created/updated separate PRs for
com_banners #6934
com_contact #6938
com_newsfeeds #6936

Bakual · 2015-05-14T12:32:41Z

However, if your SQL improves the performance (and lookup in the object is faster) then I think we should change that SQL to your suggestion.

I'd say a group by should be faster than four joins. But I would have to test it to really verify.

As I need the numbers (including 0) in the records of the categories anyway, I think that my SQL is easier. E.g. if a table (eg com_content) does not have any Archived items, the column with "0" values will be displayed.

That's a good point. Could be tricky to detect which states the extension uses. Your solution is indeed easier for that.

hans2103 · 2015-05-14T12:53:10Z

@test succes

Tested both desktop and mobile.
Looks great.
Useful PR for doing housecleaning and detecting empty categories.

woluweb · 2015-05-19T00:05:18Z

On I have tested further : indeed, on issue #6934 (count for BANNERS), I noticed that clicking on "zeros" would still show all banners of the category, no matter their "status".
But apparently, this little bug only occurs for com_banners (works fine for the current RFC com_content, and also for com_contact and com_newsfeed)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

tecpromotion · 2015-05-30T15:10:41Z

tested successfully. #jab15

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

Bakual · 2015-06-03T13:50:01Z

Merged with c57e644 into 3.5-dev.
Solved a small merge conflict on the way.

Thanks!

infograf768 · 2015-11-03T06:55:49Z

@pe7er @Bakual
In Hathor, we get the Notices as explained above:
#6916 (comment)

This needs correcting or going back in Hathor to the former display.

infograf768 · 2015-11-03T07:02:24Z

Found the culprit, now making a PR

infograf768 · 2015-11-03T07:12:46Z

See PR here: #8254

Wertos · 2016-03-12T06:37:05Z

The site of about 85,000 materials and 100 categories. In the transition to the category management page opens a minute. There is possible to disable counting?

roland-d · 2016-03-12T07:27:13Z

@Wertos There is no clean way at the moment to disable the counting but a quick hack would be to change the name countItems in administrator/components/com_content/helpers/content.php to something else. This is a core-hack and not recommended. @pe7er Perhaps we should add a switch for turning it on/off or find out why it takes so long? Are we missing an index?

wilsonge · 2016-03-13T22:12:04Z

@Wertos @roland-d can you guys please open a new issue for this so I can keep track of it please - nearly missed this tucked away in an old issue. Thanks!

pe7er · 2016-03-14T11:58:21Z

@Wertos Thanks for reporting this issue.
@roland-d I'll try to look at this issue at the end of this week.

brianteeman · 2016-03-14T12:01:27Z

I am in the process of building a site with 80,000 in over 1000 categories
for testing - but it is taking a while to generate - 2 hours so far and
only half way there

On 14 March 2016 at 11:58, Peter Martin notifications@github.com wrote:

@Wertos https://github.com/Wertos Thanks for reporting this issue.
@roland-d https://github.com/roland-d I'll try to look at this issue at
the end of this week.

—
Reply to this email directly or view it on GitHub
#6916 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

brianteeman · 2016-03-14T13:58:51Z

@pe7er @Wertos @roland-d please see #9420 and continue the discussion there and not on this closed issue

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6916.}

Added Article count (published, unpublished, trashed) to Category Man…

00798d6

…ager for com_content component.

zero-24 added the PR-staging label May 10, 2015

joomla-cms-bot added the Language Change This is for Translators label May 10, 2015

Added Article count in com_content component + direct links to Catego…

1c0e496

…ry Manager

zero-24 added the Feature label May 10, 2015

Added Archived Article count to Category Manager

e3ead0a

Changed codestyle (spaces -> tabs) + added hidden phone class

a2e28b2

Fixed undefined constant + footer td colspan

d173053

pe7er added 2 commits May 14, 2015 12:29

Deleted own helper file & moved SQL to existing one

cf3a38a

Deleted own helper file & moved SQL to existing one - fix with added …

1fcb8af

…space after comma in function call for Travis

pe7er mentioned this pull request May 14, 2015

Added countItems to com_contact helper file #6938

Closed

zero-24 added the RTC This Pull Request is Ready To Commit label May 31, 2015

Bakual added this to the Joomla! 3.5.0 milestone Jun 3, 2015

Bakual pushed a commit that referenced this pull request Jun 3, 2015

[imp] Adds Item count to Category Manager. Closes #6916.

c57e644

Bakual closed this Jun 3, 2015

ggppdk mentioned this pull request Jul 19, 2015

Filter on multiple Access Levels, Authors, Categories, and Tags #5474

Closed

roland-d pushed a commit that referenced this pull request Aug 6, 2015

[imp] Adds Item count to Category Manager. Closes #6916.

cc080a9

zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015

pe7er deleted the category-manager-article-count branch November 5, 2015 00:08

brianteeman mentioned this pull request Mar 14, 2016

New category count feature performance degrade #9420

Closed

Added Article count (published, unpublished, trashed) to Category Man… #6916

Added Article count (published, unpublished, trashed) to Category Man… #6916

Conversation

pe7er commented May 10, 2015

Testing instruction

Test before Patch

Test after applying Patch

Test the Category Manager with other core components

brianteeman commented May 10, 2015

[Testing instruction will follow soon...]

pe7er commented May 10, 2015

zero-24 commented May 10, 2015

pe7er commented May 10, 2015

zero-24 commented May 10, 2015

brianteeman commented May 10, 2015

zero-24 commented May 10, 2015

brianteeman commented May 10, 2015

pe7er commented May 10, 2015

brianteeman commented May 10, 2015

- The Menu Manager shows these 3 states too. Menus > Menu Manager.

Bakual commented May 10, 2015

Bakual commented May 10, 2015

pe7er commented May 10, 2015

dgrammatiko commented May 10, 2015

pe7er commented May 10, 2015

brianteeman commented May 10, 2015

ghost commented May 10, 2015

pe7er commented May 10, 2015

dgrammatiko commented May 10, 2015

pe7er commented May 10, 2015

pe7er commented May 10, 2015

pe7er commented May 10, 2015

pe7er commented May 10, 2015

pe7er commented May 14, 2015

pe7er commented May 14, 2015

pe7er commented May 14, 2015

Bakual commented May 14, 2015

hans2103 commented May 14, 2015

woluweb commented May 19, 2015

tecpromotion commented May 30, 2015

Bakual commented Jun 3, 2015

infograf768 commented Nov 3, 2015

infograf768 commented Nov 3, 2015

infograf768 commented Nov 3, 2015

Wertos commented Mar 12, 2016

roland-d commented Mar 12, 2016

wilsonge commented Mar 13, 2016

pe7er commented Mar 14, 2016

brianteeman commented Mar 14, 2016

brianteeman commented Mar 14, 2016