Category Manager News Feeds count #6936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $query; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Travis what you to remove the line 52 here 😄
FILE: ...oomla-cms/administrator/components/com_newsfeeds/helpers/countitems.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
52 | ERROR | Additional whitespace found at end of file
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
|
grrr... 😄 |
|
@test succes Tested both desktop and mobile. |
|
nothing to mention, works fine This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936. |
|
Thanks for testing. RTC'ing now! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936. |
|
works fine - a hover tooltip on the icons on top of table will be nice This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936. |
Bakual
pushed a commit
that referenced
this pull request
Jun 3, 2015
|
Merged with a8e866f into Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates in "Category Manager: News Feeds" 4 new columns with the number of newsfeeds per category. It contains a helper file for com_newsfeeds that is used in com_categories to calculate the number of newsfeed items (published, unpublished, archived, and trashed) in each category.
Test instructions:
The Category Manager: News Feeds (Components > NewsFeeds > Categories) does not display the number of News Feeds in each category.
Create some new newsfeeds that are unpublished, trashed & archived.
Note This patch works only in combination with #6916. Install both #6916 and this patch (the order of installation does not matter, you just need both).
After installing the patch, The Category Manager: NewsFeeds (Components > NewsFeeds > Categories) should displays 4 new columns.
Please also check this patch with the Hathor admin template.