Category Manager News Feeds count #6936

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
7 participants
@pe7er
Contributor

pe7er commented May 13, 2015

This patch creates in "Category Manager: News Feeds" 4 new columns with the number of newsfeeds per category. It contains a helper file for com_newsfeeds that is used in com_categories to calculate the number of newsfeed items (published, unpublished, archived, and trashed) in each category.

Test instructions:

The Category Manager: News Feeds (Components > NewsFeeds > Categories) does not display the number of News Feeds in each category.

screen shot 2015-05-13 at 15 17 09

Create some new newsfeeds that are unpublished, trashed & archived.
Note This patch works only in combination with #6916. Install both #6916 and this patch (the order of installation does not matter, you just need both).
After installing the patch, The Category Manager: NewsFeeds (Components > NewsFeeds > Categories) should displays 4 new columns.

screen shot 2015-05-13 at 15 17 09

Please also check this patch with the Hathor admin template.

@zero-24 zero-24 added the PR-staging label May 13, 2015

+ return $query;
+ }
+}
+

This comment has been minimized.

@zero-24

zero-24 May 13, 2015

Contributor

@pe7er

Travis what you to remove the line 52 here 😄

FILE: ...oomla-cms/administrator/components/com_newsfeeds/helpers/countitems.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 52 | ERROR | Additional whitespace found at end of file
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
@zero-24

zero-24 May 13, 2015

Contributor

@pe7er

Travis what you to remove the line 52 here 😄

FILE: ...oomla-cms/administrator/components/com_newsfeeds/helpers/countitems.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 52 | ERROR | Additional whitespace found at end of file
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
@pe7er

This comment has been minimized.

Show comment
Hide comment
@pe7er

pe7er May 13, 2015

Contributor

grrr... 😄
I've changed it and added the new PR.

Contributor

pe7er commented May 13, 2015

grrr... 😄
I've changed it and added the new PR.

@hans2103

This comment has been minimized.

Show comment
Hide comment
@hans2103

hans2103 May 14, 2015

Contributor

@test succes

Tested both desktop and mobile.

Contributor

hans2103 commented May 14, 2015

@test succes

Tested both desktop and mobile.

@zero-24 zero-24 added the New Feature label May 15, 2015

@woluweb

This comment has been minimized.

Show comment
Hide comment
@woluweb

woluweb May 19, 2015

nothing to mention, works fine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

woluweb commented May 19, 2015

nothing to mention, works fine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 May 19, 2015

Contributor

Thanks for testing. RTC'ing now!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

Contributor

zero-24 commented May 19, 2015

Thanks for testing. RTC'ing now!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

@zero-24 zero-24 added the RTC label May 19, 2015

@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.5.0 milestone May 21, 2015

@coolwebcreations

This comment has been minimized.

Show comment
Hide comment
@coolwebcreations

coolwebcreations May 30, 2015

works fine - a hover tooltip on the icons on top of table will be nice


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

works fine - a hover tooltip on the icons on top of table will be nice


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6936.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 3, 2015

Contributor

Merged with a8e866f into 3.5-dev.

Thanks!

Contributor

Bakual commented Jun 3, 2015

Merged with a8e866f into 3.5-dev.

Thanks!

@Bakual Bakual closed this Jun 3, 2015

@zero-24 zero-24 removed the RTC label Oct 14, 2015

@pe7er pe7er deleted the pe7er:category-manager-newsfeed-count branch Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment