Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in "Install localised content" #7281

Closed
wants to merge 1 commit into from

Conversation

smz
Copy link
Contributor

@smz smz commented Jun 28, 2015

Description

This fixes a couple of minor issues in the localised content installation

Steps to reproduce the issue

  • Perform Joomla! installation
  • Select "Extra steps: Install languages"
  • In "Install Language Packages" select one or more additional language
  • Set "Activate the multilingual feature:" to "Yes"
  • Select "Install localised content"
  • When installation has completed login in the backend and examine the automatically installed articles

Expected result

  • Articles titles should be "Article" (or the corresponding translation) + Language code
  • Articles should have empty metadata

Actual result

  • In some language (e.g. Italian) the translation of the word "Article" might be incorrect.
  • In the "Meta Description:" you'll find a JSON encoded string: {"robots":"","author":"","rights":"","xreference":""}

Testing instructions

Apply this patch and perform a new installation, as above: actual result should match expected result

Additional comments

Fixes #7280

@smz
Copy link
Contributor Author

smz commented Jun 28, 2015

@infograf768
Thanks for suggesting the usage of the COM_CONTENT_CONTENT_TYPE_ARTICLE string! 👍

@brianteeman
Copy link
Contributor

I think you are wrong about changing to empty metadata.
When you create a brand new article on a clean install and then check the database you will see that the metadata field contains {"robots":"","author":"","rights":"","xreference":""}


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7281.

@smz
Copy link
Contributor Author

smz commented Jun 28, 2015

@brianteeman: Exactly, and that's the issue! 😄

@Bakual
Copy link
Contributor

Bakual commented Jun 28, 2015

@brianteeman This is about metadesc, not metadata 😄

@brianteeman
Copy link
Contributor

Oops


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7281.

@smz
Copy link
Contributor Author

smz commented Jun 28, 2015

😜

@infograf768
Copy link
Member

OK for me. Simple patch.

@anibalsanchez
Copy link
Contributor

#Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7281.

@smz
Copy link
Contributor Author

smz commented Jun 29, 2015

@anibalsanchez Thanks Anibal! May I ask you the favour to give a try at #7247 too?

@smz
Copy link
Contributor Author

smz commented Jun 29, 2015

Sorry, I meant to say #7248 😄

@zero-24
Copy link
Contributor

zero-24 commented Jun 30, 2015

RTC Thanks 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7281.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jun 30, 2015
@zero-24 zero-24 modified the milestone: Joomla! 3.4.4 Jul 2, 2015
@smz
Copy link
Contributor Author

smz commented Jul 2, 2015

Maybe this too (which is trivial) can go in 3.4.3. But that's not much important...

@Kubik-Rubik
Copy link
Member

Thank you @smz! Merged.

@smz smz deleted the InstallationLanguages branch July 4, 2015 02:43
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically installed localised content: errors in metadata
8 participants