Change Travis build and Composer lock to track extra dev dependencies #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ | |||
| JLoader::registerPrefix('J', JPATH_PLATFORM . '/cms', false, true); | |||
|
|
|||
| // Create the Composer autoloader | |||
| $loader = require_once JPATH_LIBRARIES . '/vendor/autoload.php'; | |||
| $loader = require JPATH_LIBRARIES . '/vendor/autoload.php'; | |||
There was a problem hiding this comment.
Why is this change? I don't understand.
There was a problem hiding this comment.
If you require a file once, subsequent requires return a boolean true. Running PHPUnit with this changed caused a "Call to a member function unregister() on a non-object" message. This ensures that every time this file is called at this point, we get the returned autoloader object and not a boolean value.
There was a problem hiding this comment.
Ah, learned something again 😄
Bakual
pushed a commit
that referenced
this pull request
Jul 3, 2015
Change Travis build and Composer lock to track extra dev dependencies
|
A new branch RemoveGitterFromTravis appeared in joomla/joomla-cms: is it related to this? |
|
Nah, that's stupid me doing a PR from the wrong repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having Travis download and install extra dev dependencies, this changes the build process to include those dependencies in our composer.lock file (so in theory all Travis has to do is clone the source).
This has already run at https://travis-ci.org/mbabker/joomla-cms/builds/69462829 and built successfully.