Cleaning - JEditor

[Mathewlenning]

Refactored JEditor::attach Removed some duplication and redundant ELSE clause

[wilsonge]

Just out of interest. Is this actually used anywhere to your knowledge. I was going to write unit tests for this method like a month ago. But found the method was totally broken and not used in the CMS (e.g. we only take a JEditor object but then diff the methods in it against JPlugin!?)

Fwiw the same method with the same level of brokeness exists in JCaptcha as well (except there we still take a JEditor object and diff it against JPlugin #copyPasteWins)

[Mathewlenning]

Sorry, but I have no clue if it is or not. I kind of just randomly open files until I find something that makes my head hurt and then start refactoring =^O

This one was for an article I'm writing on improving the code base.

Sincerely,
Mathew Lenning

P.S. This message was sent via iPhone, so please forgive any errors

On Oct 1, 2015, at 6:32 PM, George Wilson notifications@github.com wrote:

Just out of interest. Is this actually used anywhere to your knowledge. I was going to write unit tests for this method like a month ago. But found the method was totally broken and not used in the CMS (e.g. we only take a JEditor object but then diff the methods in it against JPlugin!?)

―
Reply to this email directly or view it on GitHub.

[Kubik-Rubik]

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. I will close this PR now. If you want to update your PR, then this can be re-opened.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7993.}