Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on #8085 - refactor com_contact form to support renderField #8473

Merged
merged 13 commits into from Dec 6, 2015
Merged

Follow up on #8085 - refactor com_contact form to support renderField #8473

merged 13 commits into from Dec 6, 2015

Commits on Nov 17, 2015

  1. Refactor the form layout to make use of the renderField method

    The following changes were made to this file, starting from the top:
    - Removed the error-handle code block at the top that seemed to be left over from Joomla! 1.6
    - Added the well CSS class suffix to the form to match the output / markup of com_users.registration and login
    - Rewritten the foreach loop to fetch the fieldset and field information from the xml file and make use of the renderField method
    - Adjusted the markup containing the button and hidden field/s to match the output / markup of com_users.registration and login
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    4e4a760 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary jimport and unused "com_media" params

    The following changes were made to this file, starting from the top:
    - Removed the com_media variable assignment since there seem to be no reference where this was used
    - Removed unnecessary jimport for jhtml bootstrap
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    91c01f5 View commit details
    Browse the repository at this point in the history
  3. Add component specific renderfield JLayout override

    This adds a component specific renderfield JLayout override. The "optional" addition to the label for required fields was moved from the com_contact form layout in here to be able to use the renderField method in the layout file.
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    bfd6c43 View commit details
    Browse the repository at this point in the history
  4. Change contact form fieldset label to match the com_users schema

    Change contact form fieldset label to match the com_users schema and add component specific "* Requied field" "constant"
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    6b9ca1d View commit details
    Browse the repository at this point in the history
  5. Add spacer and update fieldset label format to match what is used in …

    …com_users
    
    Besides reordering the label and description attributes in this file which, to be honest, was more about finding peace and satisfying my OCD, I've changed the fieldset label to match the format that is used in com_users and added a spacer label to output the *Required field hint for the form.
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    202e838 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ebd0f12 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    92467ac View commit details
    Browse the repository at this point in the history
  8. Introduce extract($displayData); to make the variables more accessible

    These changes allow a more direct access to input, label and the options
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    fe6f57a View commit details
    Browse the repository at this point in the history
  9. Introduce extract($displayData); to make the variables more accessible

    As well es for the renderfield.php the proposed changes allow a more direct access the the variables used in this file
    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    e624050 View commit details
    Browse the repository at this point in the history
  10. Add whitespace to fieldset

    matrikular committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    e119c7f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2015

  1. Configuration menu
    Copy the full SHA
    aae307c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2015

  1. Configuration menu
    Copy the full SHA
    a16cc17 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2015

  1. Merge branch 'staging' of https://github.com/joomla/joomla-cms into p…

    …atch-2
    
    Conflicts:
    	components/com_contact/views/contact/tmpl/default.php
    matrikular committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    afbc479 View commit details
    Browse the repository at this point in the history