Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner client ordering #8662

Closed
wants to merge 2 commits into from
Closed

Banner client ordering #8662

wants to merge 2 commits into from

Conversation

brianteeman
Copy link
Contributor

In com_banners clients the dropdown select has both Name and Client ordering
In this view the column heading is Client not Name
If you try the ordering then you will see that the Name ordering sorts by the Client column and the Client ordering does nothing

Apply this patch and You only have Client ordering which works

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 6c45ff5

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8662.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 6c45ff5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8662.

@brianteeman
Copy link
Contributor Author

Setting RTC. Thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8662.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 3, 2016
@rdeutz rdeutz added this to the Joomla 3.5.1 milestone Jan 6, 2016
@wilsonge wilsonge modified the milestones: Joomla! 3.5.0, Joomla 3.5.1 Jan 17, 2016
@wilsonge wilsonge closed this in bcff345 Jan 17, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
@brianteeman brianteeman deleted the bannerclient branch January 17, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants