[imp] Implement Backend Language Switcher #9126

infograf768 · 2016-02-15T11:19:06Z

This PR adds a new Toolbar Button to let admin switch the Backend Language to any language.
It replaces #9119 which was only letting switch to the Default Admin Language.

The purpose of the PR is to facilitate the work of devs, translators and admins in general.

After PR, one will get:

@richard67 @andrepereiradasilva @Kubik-Rubik
Thanks for testing.

dgrammatiko · 2016-02-15T11:25:37Z

administrator/components/com_languages/controllers/installed.php

+	 * @return  void
+	 */
+	public function switchAdminLanguage()
+	{


If you allow a param in this function ($languageId) then we can use it in a module lang switcher.
Also a check

if (isset($languageId)) { JFactory::getApplication()->setUserState('application.lang', $languageId); } else { $cid = $this->input->get('cid', ''); ... }

You mean we "could" use it, right?
Do you want to add one to core or would that just be to let a 3rd party create one?

Also, I would rather, if @joomla/cms-maintainers agree with your proposal, use $languageTag as it is not an id which is for $whatever in
`JFactory::getApplication()->setUserState('application.lang', $whatever)'

but the language tag, i.e fr-FR, en-GB, etc.

Yup!
I find this an essential addition for backend users with multilingual sites. Right now I need to install 3PD extension for this really basic functionality.
Figuring out the variable type by reading the code is hard but yes $languageTag seems more appropriate! (I thought $cid was referring to a number)

andrepereiradasilva · 2016-02-15T11:33:22Z

@infograf768 for usability how about reordering the buttons, first the ones related with options selected, them the general ones (not related to the options selected).

Also what to do you think of instead "Switch Backend Language" having "Switch to Language". Since the button only appear on the admin languages, IMHO probably makes more sense.

In other words:

instead of: Default | Install Languages | Switch Backend Language

this: Default | Switch to Language | Install Languages

infograf768 · 2016-02-15T11:36:25Z

@andrepereiradasilva
Ok for the order. Will wait all comments to update.
Asking @brianteeman for the string change.

richard67 · 2016-02-15T11:37:10Z

I have tested this item ✅ successfully on dbd6920

Tested with success. Works as discussed in #9119 at the end.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

MATsxm · 2016-02-15T12:08:43Z

I have tested this item ✅ successfully on dbd6920

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

MATsxm · 2016-02-15T12:09:00Z

At this point - works as described.

NOTE: the btn appears even if we have only one language istalled on backend

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

brianteeman · 2016-02-15T16:12:51Z

For consistency I think that this should be referred to as Administrator Language and not Backend Language

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

joomla-cms-bot · 2016-02-16T06:57:50Z

This PR has received new commits.

CC: @MATsxm, @richard67

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

infograf768 · 2016-02-16T07:05:46Z

I have modified the language strings as well as the order of the buttons.

This gives:

@MATsxm The button will behave the same way as the "Default" button which also displays when only one language is installed.

@andrepereiradasilva I guess that Switch Language does not need the "to".

Please test again

@dgt41
I prefer to let you make a specific PR for your request as I would not know where to stop the "else".

richard67 · 2016-02-16T10:37:12Z

I have tested this item ✅ successfully on 295bf8c

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

MATsxm · 2016-02-16T12:55:14Z

I have tested this item ✅ successfully on 295bf8c

#9126 works as expected - Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

infograf768 · 2016-02-16T14:03:21Z

rtc. thanks for feedback and testing.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

language tag.

joomla-cms-bot · 2016-02-17T11:32:17Z

This PR has received new commits.

CC: @MATsxm, @richard67

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

infograf768 · 2016-02-17T11:36:17Z

Folks, I will ask you to test again, sorry.
@brianteeman suggested that I change the success message to display the language Name and not the language Tag.
I think it is indeed much better.

One will now get:

@richard67 @MATsxm @andrepereiradasilva @brianteeman

richard67 · 2016-02-17T11:47:31Z

I have tested this item ✅ successfully on 49595b0

Just tested, works as before plus language full name instead of tag is used in the success message.

@infograf768 What last screenshot does not show (because I think you switched from English to English) is that the success message is in the language from before switching, as your first screenshot in the test description shows (switched from English to Italian: Title "Messagio" in Italian but message content in English. I guess we cannot change this in an easy way, otherwise you would have done it, right? Or is it by purpose?

I also assume that there is no other easy way to get the language full name so you have to parse the XML file, right?

Or could it maybe be obtained from the language lists's 1st column, e.g. with jQuery?

Anyway, for me it is good enough as it is now, and I hope it will go into 3.5.0 Beta 3 or RC.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

MATsxm · 2016-02-17T11:56:23Z

I have tested this item ✅ successfully on 49595b0

Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

infograf768 · 2016-02-17T11:56:29Z

as your first screenshot in the test description shows (switched from English to Italian: Title "Messagio" in Italian but message content in English. I guess we cannot change this in an easy way, otherwise you would have done it, right?

Same issue when the user is set to Default Language and another language is set to default. The content of the message is picked from the former language. No idea how to solve this. If it is possible this should be another PR imho.

I did parse the xx-XX.xml file indeed. Easy enough. code is

        $file = JPATH_ADMINISTRATOR . '/language/' . $cid . '/' . $cid . '.xml';
        $info = JInstaller::parseXMLInstallFile($file);
        $languageName = $info['name'];

        if ($model->switchAdminLanguage($cid))
        {
            $msg = JText::sprintf('COM_LANGUAGES_MSG_SWITCH_ADMIN_LANGUAGE_SUCCESS', $languageName);
            $type = 'message';
        }
        else

richard67 · 2016-02-17T11:59:02Z

@infograf768 Thanks for the info, I just was curious. For me it is fine now as it is.

andrepereiradasilva · 2016-02-17T12:00:11Z

i think you could also use JLanguage::parseXMLLanguageFile($path); don't really know the difference.

brianteeman · 2016-02-17T12:01:02Z

@richard67 @infograf768 isnt the message always in english right now because it is a new language string that doesnt exist in the other languages so en-gb is always used as a fallback

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

brianteeman · 2016-02-17T12:01:33Z

I have tested this item ✅ successfully on 49595b0

Works perfectly for me - thanks @infograf768

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9126.}

richard67 · 2016-02-17T12:02:14Z

@brianteeman Ahhhh, sure, you are right. Silly me!

infograf768 · 2016-02-17T12:08:18Z

@andrepereiradasilva

i think you could also use JLanguage::parseXMLLanguageFile($path); don't really know the difference.

It is deprecated.
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/helper.php#L229-L231

andrepereiradasilva · 2016-02-17T12:15:52Z

not that one, this one
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/language.php#L1365

gwsdesk · 2016-02-17T13:37:08Z

Works as intended for me. Thanks JM

[imp] Implement Backend Language Switcher

richard67 · 2016-02-18T10:34:09Z

@infograf768 Thanks a lot for this great new feature. It helps a lot with testing (multi) language stuff in backend. I think it is worth to be mentioned in the new features of the release notes with an own head line.

infograf768 · 2016-02-18T10:52:51Z

BTW:

isnt the message always in english right now because it is a new language string that doesnt exist in the other languages so en-gb is always used as a fallback

Nope. As I stated above #9126 (comment) the message is in the former language. It is the same as Default change as you can test by setting an admin language to Default when logged with a user set to use Default language.

infograf768 · 2016-02-18T12:01:36Z

I have a solution for that. Will make a new PR for both Default and Switch.

infograf768 added 3 commits February 15, 2016 10:02

Implements backend language switcher

5c86167

doc comment

addf9cf

Merge remote-tracking branch 'upstream/staging' into admin_switcher

dbd6920

joomla-cms-bot added Language Change This is for Translators PR-staging labels Feb 15, 2016

infograf768 mentioned this pull request Feb 15, 2016

[imp] Force loading the default administrator language #9119

Closed

dgrammatiko reviewed Feb 15, 2016
View reviewed changes

String and order changes

295bf8c

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 16, 2016

Changing the success message to display the language name instead of the

49595b0

language tag.

wilsonge added a commit that referenced this pull request Feb 18, 2016

Merge pull request #9126 from infograf768/admin_switcher

029b170

[imp] Implement Backend Language Switcher

wilsonge merged commit 029b170 into joomla:staging Feb 18, 2016

wilsonge added this to the Joomla! 3.5.0 milestone Feb 18, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 18, 2016

infograf768 deleted the admin_switcher branch February 18, 2016 10:40

This was referenced Feb 18, 2016

[bug] Switching message language when changing admin language #9150

Merged

Correcting regression due to the merge of #9101 #9159

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[imp] Implement Backend Language Switcher #9126

[imp] Implement Backend Language Switcher #9126

infograf768 commented Feb 15, 2016

dgrammatiko Feb 15, 2016

infograf768 Feb 15, 2016

dgrammatiko Feb 15, 2016

andrepereiradasilva commented Feb 15, 2016

infograf768 commented Feb 15, 2016

richard67 commented Feb 15, 2016

MATsxm commented Feb 15, 2016

MATsxm commented Feb 15, 2016

brianteeman commented Feb 15, 2016

joomla-cms-bot commented Feb 16, 2016

infograf768 commented Feb 16, 2016

richard67 commented Feb 16, 2016

MATsxm commented Feb 16, 2016

infograf768 commented Feb 16, 2016

joomla-cms-bot commented Feb 17, 2016

infograf768 commented Feb 17, 2016

richard67 commented Feb 17, 2016

MATsxm commented Feb 17, 2016

infograf768 commented Feb 17, 2016

richard67 commented Feb 17, 2016

andrepereiradasilva commented Feb 17, 2016

brianteeman commented Feb 17, 2016

brianteeman commented Feb 17, 2016

richard67 commented Feb 17, 2016

infograf768 commented Feb 17, 2016

andrepereiradasilva commented Feb 17, 2016

gwsdesk commented Feb 17, 2016

richard67 commented Feb 18, 2016

infograf768 commented Feb 18, 2016

infograf768 commented Feb 18, 2016

[imp] Implement Backend Language Switcher #9126

[imp] Implement Backend Language Switcher #9126

Conversation

infograf768 commented Feb 15, 2016

dgrammatiko Feb 15, 2016

Choose a reason for hiding this comment

infograf768 Feb 15, 2016

Choose a reason for hiding this comment

dgrammatiko Feb 15, 2016

Choose a reason for hiding this comment

andrepereiradasilva commented Feb 15, 2016

infograf768 commented Feb 15, 2016

richard67 commented Feb 15, 2016

MATsxm commented Feb 15, 2016

MATsxm commented Feb 15, 2016

brianteeman commented Feb 15, 2016

joomla-cms-bot commented Feb 16, 2016

infograf768 commented Feb 16, 2016

richard67 commented Feb 16, 2016

MATsxm commented Feb 16, 2016

infograf768 commented Feb 16, 2016

joomla-cms-bot commented Feb 17, 2016

infograf768 commented Feb 17, 2016

richard67 commented Feb 17, 2016

MATsxm commented Feb 17, 2016

infograf768 commented Feb 17, 2016

richard67 commented Feb 17, 2016

andrepereiradasilva commented Feb 17, 2016

brianteeman commented Feb 17, 2016

brianteeman commented Feb 17, 2016

richard67 commented Feb 17, 2016

infograf768 commented Feb 17, 2016

andrepereiradasilva commented Feb 17, 2016

gwsdesk commented Feb 17, 2016

richard67 commented Feb 18, 2016

infograf768 commented Feb 18, 2016

infograf768 commented Feb 18, 2016