Improving JTableNested::delete() #9204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on baf3f1e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204. |
|
I have tested by deleting a category, restoring from Trash, deleting again and empty Trash. All still working as expected |
|
I have tested this item ✅ successfully on baf3f1e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204. |
|
Flagging Needs Review (as kind of requested) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204. |
|
Merged with 342da16 - thanks Hannes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This change brings a performance improvement to JTableNested::delete(). This eliminates one query per item to be deleted. If you would for example clear your trash with 200 categories, this means 200 queries less with this change. Since we are using JTableNested for the assets table, this would mean that also deleting articles would receive a performance boost.
Testing Instructions
YAUTPR - Yet Another Un-Testable Pull Request
You can test this PR by deleting a category for example and afterwards everything should still work. However, this actually needs a proper code review by a seasoned developer/maintainer.