New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving JTableNested::delete() #9204

Closed
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
6 participants
@Hackwar
Member

Hackwar commented Feb 24, 2016

Summary of Changes

This change brings a performance improvement to JTableNested::delete(). This eliminates one query per item to be deleted. If you would for example clear your trash with 200 categories, this means 200 queries less with this change. Since we are using JTableNested for the assets table, this would mean that also deleting articles would receive a performance boost.

Testing Instructions

YAUTPR - Yet Another Un-Testable Pull Request
You can test this PR by deleting a category for example and afterwards everything should still work. However, this actually needs a proper code review by a seasoned developer/maintainer.

@Gerlof

This comment has been minimized.

Gerlof commented Feb 29, 2016

I have tested this item successfully on baf3f1e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.

@gwsdesk

This comment has been minimized.

gwsdesk commented Feb 29, 2016

I have tested by deleting a category, restoring from Trash, deleting again and empty Trash. All still working as expected

@gwsdesk

This comment has been minimized.

gwsdesk commented on baf3f1e Feb 29, 2016

tested and works as expected

@gwsdesk

This comment has been minimized.

gwsdesk commented Feb 29, 2016

I have tested this item successfully on baf3f1e

Tested and works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.

@wilsonge wilsonge added this to the Joomla! 3.6.0 milestone Feb 29, 2016

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Mar 9, 2016

Flagging Needs Review (as kind of requested)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.

@wilsonge

This comment has been minimized.

Contributor

wilsonge commented Apr 9, 2016

Merged with 342da16 - thanks Hannes :)

@wilsonge wilsonge closed this Apr 9, 2016

@Hackwar Hackwar deleted the Hackwar:tablenesteddelete branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment