Sessionfix

[wilsonge]

Pull Request for Issue #8851 .

Summary of Changes

This fixes two things:

1. The double login that occurs when your session expires
2. When restarting a session the id wasn't being regenerated properly as the session hadn't been started yet. This was causing PHP Warnings in PHP 7 (ref: Fix restart method causing fatal error #9555 //cc @andrepereiradasilva)

Testing Instructions

1. Let your session expire (it might help lowering the session time to 1-2 minutes in global configuration)
2. Try and login
3. Login a second time
4. Apply patch
5. Let session expire again
6. Login first time around successfully.

[brianteeman]

I have tested this item ✅ successfully on d08fd12

Tested with php 5.6 and 7

great stuff!!!!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.}

[richard67]

Tested with success on PHP 5.6. Now will test on PHP 7 to see if there are any warnings.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.}

[richard67]

I have tested this item ✅ successfully on d08fd12

I tested with both PHP 5.6 and 7.

The thing with warnings in PHP 7 I could not reproduce. Did not have any warning without and with this PR.

Maybe the reason is that I have session handler = database and not PHP?

Anyway: This PR works as smooth as a fresh creamed baby butt.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.}

[wilsonge]

I don't have a PHP 7 set up at the moment as just got a new laptop. But I think that @andrepereiradasilva could only get it when running the sample command line script I had in #9555

[richard67]

Anyway, your sessionfix does the session fix 😄

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.}

[MATsxm]

I have tested this item ✅ successfully on d08fd12

Good morning... A bit late but success on PHP 5.6 & 7 - Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.}

[andrepereiradasilva]

@wilsonge just tested. this also solves the warnings on php 7 i had on CLI scripts too (#9555 (comment)).

[wilsonge]

Woot :D