New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessionfix #9619

Merged
merged 3 commits into from Mar 27, 2016

Conversation

Projects
None yet
6 participants
@wilsonge
Contributor

wilsonge commented Mar 27, 2016

Pull Request for Issue #8851 .

Summary of Changes

This fixes two things:

  1. The double login that occurs when your session expires
  2. When restarting a session the id wasn't being regenerated properly as the session hadn't been started yet. This was causing PHP Warnings in PHP 7 (ref: #9555 //cc @andrepereiradasilva)

Testing Instructions

  1. Let your session expire (it might help lowering the session time to 1-2 minutes in global configuration)
  2. Try and login
  3. Login a second time
  4. Apply patch
  5. Let session expire again
  6. Login first time around successfully.

@wilsonge wilsonge changed the title from Sessionfix to Double login fix Mar 27, 2016

@brianteeman brianteeman changed the title from Double login fix to Sessionfix Mar 27, 2016

@brianteeman brianteeman added this to the Joomla 3.5.1 milestone Mar 27, 2016

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Mar 27, 2016

Contributor

I have tested this item successfully on d08fd12

Tested with php 5.6 and 7

great stuff!!!!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

Contributor

brianteeman commented Mar 27, 2016

I have tested this item successfully on d08fd12

Tested with php 5.6 and 7

great stuff!!!!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

@richard67

This comment has been minimized.

Show comment
Hide comment
@richard67

richard67 Mar 27, 2016

Contributor

Tested with success on PHP 5.6. Now will test on PHP 7 to see if there are any warnings.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

Contributor

richard67 commented Mar 27, 2016

Tested with success on PHP 5.6. Now will test on PHP 7 to see if there are any warnings.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

@richard67

This comment has been minimized.

Show comment
Hide comment
@richard67

richard67 Mar 27, 2016

Contributor

I have tested this item successfully on d08fd12

I tested with both PHP 5.6 and 7.

The thing with warnings in PHP 7 I could not reproduce. Did not have any warning without and with this PR.

Maybe the reason is that I have session handler = database and not PHP?

Anyway: This PR works as smooth as a fresh creamed baby butt.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

Contributor

richard67 commented Mar 27, 2016

I have tested this item successfully on d08fd12

I tested with both PHP 5.6 and 7.

The thing with warnings in PHP 7 I could not reproduce. Did not have any warning without and with this PR.

Maybe the reason is that I have session handler = database and not PHP?

Anyway: This PR works as smooth as a fresh creamed baby butt.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Mar 27, 2016

Contributor

I don't have a PHP 7 set up at the moment as just got a new laptop. But I think that @andrepereiradasilva could only get it when running the sample command line script I had in #9555

Contributor

wilsonge commented Mar 27, 2016

I don't have a PHP 7 set up at the moment as just got a new laptop. But I think that @andrepereiradasilva could only get it when running the sample command line script I had in #9555

@richard67

This comment has been minimized.

Show comment
Hide comment
@richard67

richard67 Mar 27, 2016

Contributor

Anyway, your sessionfix does the session fix 😄

Contributor

richard67 commented Mar 27, 2016

Anyway, your sessionfix does the session fix 😄

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Mar 27, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

Contributor

brianteeman commented Mar 27, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

@joomla-cms-bot joomla-cms-bot added the RTC label Mar 27, 2016

@MATsxm

This comment has been minimized.

Show comment
Hide comment
@MATsxm

MATsxm Mar 27, 2016

Member

I have tested this item successfully on d08fd12

Good morning... A bit late but success on PHP 5.6 & 7 - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

Member

MATsxm commented Mar 27, 2016

I have tested this item successfully on d08fd12

Good morning... A bit late but success on PHP 5.6 & 7 - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.

@wilsonge wilsonge merged commit 5db8892 into joomla:staging Mar 27, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 27, 2016

@andrepereiradasilva

This comment has been minimized.

Show comment
Hide comment
@andrepereiradasilva

andrepereiradasilva Mar 27, 2016

Contributor

@wilsonge just tested. this also solves the warnings on php 7 i had on CLI scripts too (#9555 (comment)).

Contributor

andrepereiradasilva commented Mar 27, 2016

@wilsonge just tested. this also solves the warnings on php 7 i had on CLI scripts too (#9555 (comment)).

@wilsonge wilsonge deleted the wilsonge:sessionfix branch Mar 27, 2016

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Mar 27, 2016

Contributor

Woot :D

Contributor

wilsonge commented Mar 27, 2016

Woot :D

@joomla joomla deleted a comment from alo24h Jan 19, 2018

@brianteeman brianteeman referenced this pull request Feb 23, 2018

Closed

[4.0] Session fix #19769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment