This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Validate that the key parameter is a string #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request validates that the `$key` parameter provided to the function is actually a string before trying to use this. I came across this as I was working to modify JTable to be able to support multiple primary keys in a somewhat transparent way. By default JTable passes through it's keys onto the database `insertObject` and `updateObject` function which works well for single keys but not properly for `insertObject` when the `$key` is an array.
LouisLandry
added a commit
that referenced
this pull request
Aug 23, 2012
Validate that the key parameter is a string
| @@ -851,7 +851,7 @@ public function insertObject($table, &$object, $key = null) | |||
|
|
|||
| // Update the primary key if it exists. | |||
| $id = $this->insertid(); | |||
| if ($key && $id) | |||
| if ($key && $id && is_string($key)) | |||
There was a problem hiding this comment.
I think that it would be enough to do if (is_string($key) && $id). If the condition fails for $key it will fail for is_string($key) too.
There was a problem hiding this comment.
But if $key would not exist you would then get a Notice: Undefined variable: key
That's why $key is tested first and cannot be left.
There was a problem hiding this comment.
Yes, but $key is by default null. I can't see any case when $key is not defined in this context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request validates that the
$keyparameter provided to the function is actually a string before trying to use this. I came across this as I was working to modify JTable to be able to support multiple primary keys in a somewhat transparent way. By default JTable passes through it's keys onto the databaseinsertObjectandupdateObjectfunction which works well for single keys but not properly forinsertObjectwhen the$keyis an array.