Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Deprecate debug plugin strings #2794

Closed
jgerman-bot opened this issue May 3, 2023 · 0 comments · Fixed by #2796
Closed

[4.4] Deprecate debug plugin strings #2794

jgerman-bot opened this issue May 3, 2023 · 0 comments · Fixed by #2796

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#40469 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/plg_system_debug.ini b/administrator/language/en-GB/plg_system_debug.ini
index 87e08c6a9853..cdb82aafd048 100644
--- a/administrator/language/en-GB/plg_system_debug.ini
+++ b/administrator/language/en-GB/plg_system_debug.ini
@@ -3,13 +3,6 @@
 ; License GNU General Public License version 2 or later; see LICENSE.txt
 ; Note : All ini files need to be saved as UTF-8
 
-PLG_DEBUG_BYTES="Bytes"
-PLG_DEBUG_CALL_STACK="Call Stack"
-PLG_DEBUG_CALL_STACK_CALLER="Caller"
-PLG_DEBUG_CALL_STACK_FILE_AND_LINE="File and line number"
-PLG_DEBUG_CALL_STACK_SAME_FILE="<em>Same as call in the line below.</em>"
-PLG_DEBUG_ERRORS="Errors"
-PLG_DEBUG_EXPLAIN="Explain"
 PLG_DEBUG_FIELD_ALLOWED_GROUPS_LABEL="Allowed Groups"
 PLG_DEBUG_FIELD_LANGUAGE_ERRORFILES_LABEL="Errors When Parsing Language Files"
 PLG_DEBUG_FIELD_LANGUAGE_FILES_LABEL="Language Files"
@@ -33,13 +26,24 @@ PLG_DEBUG_FIELD_STRIP_SUFFIX_DESC="Strip words from the end of the string. For m
 PLG_DEBUG_FIELD_STRIP_SUFFIX_LABEL="Strip From End"
 PLG_DEBUG_FIELD_TRACK_REQUEST_HISTORY_LABEL="Track Request History"
 PLG_DEBUG_FIELD_TRACK_REQUEST_HISTORY_DESC="When enabled this saves the request history data into the filesystem for future analysis. This data may include passwords and secret tokens. Only enable this for a short period of time as the file can be read by anyone with read access to the cache folder. When this setting is subsequently disabled it is strongly recommended to clear the Site Cache!"
-PLG_DEBUG_LANG_LOADED="Loaded"
-PLG_DEBUG_LANG_NOT_LOADED="Not loaded"
 PLG_DEBUG_LANGUAGE_FIELDSET_LABEL="Language"
+PLG_DEBUG_LOGGING_FIELDSET_LABEL="Logging"
+PLG_DEBUG_XML_DESCRIPTION="This plugin provides a variety of system information as well as help for the creation of translation files."
+PLG_SYSTEM_DEBUG="System - Debug"
+
+; All the following strings are deprecated and will be removed with 5.0
+PLG_DEBUG_BYTES="Bytes"
+PLG_DEBUG_CALL_STACK="Call Stack"
+PLG_DEBUG_CALL_STACK_CALLER="Caller"
+PLG_DEBUG_CALL_STACK_FILE_AND_LINE="File and line number"
+PLG_DEBUG_CALL_STACK_SAME_FILE="<em>Same as call in the line below.</em>"
+PLG_DEBUG_ERRORS="Errors"
+PLG_DEBUG_EXPLAIN="Explain"
 PLG_DEBUG_LANGUAGE_FILES_IN_ERROR="Parsing errors in language files"
 PLG_DEBUG_LANGUAGE_FILES_LOADED="Language Files Loaded"
+PLG_DEBUG_LANG_LOADED="Loaded"
+PLG_DEBUG_LANG_NOT_LOADED="Not loaded"
 PLG_DEBUG_LINK_FORMAT="Add xdebug.file_link_format directive to your php.ini file to have links for files."
-PLG_DEBUG_LOGGING_FIELDSET_LABEL="Logging"
 PLG_DEBUG_LOGS="Log Messages"
 PLG_DEBUG_LOGS_DEPRECATED_FOUND_TEXT="The code that is marked as deprecated will not work in upcoming Joomla versions, please review it."
 PLG_DEBUG_LOGS_DEPRECATED_FOUND_TITLE="%s deprecated messages logged!"
@@ -61,8 +65,8 @@ PLG_DEBUG_QUERY_DUPLICATES_NUMBER="%s duplicates"
 PLG_DEBUG_QUERY_DUPLICATES_TOTAL_NUMBER="%s duplicate found!"
 PLG_DEBUG_QUERY_EXPLAIN_NOT_POSSIBLE="EXPLAIN not possible on query: %s"
 PLG_DEBUG_QUERY_TIME="Query Time: %s"
-PLG_DEBUG_QUERY_TYPE_AND_OCCURRENCES="%2$d &#215; %1$s"
 PLG_DEBUG_QUERY_TYPES_LOGGED="%d Query Types Logged, Sorted by Occurrences."
+PLG_DEBUG_QUERY_TYPE_AND_OCCURRENCES="%2$d &#215; %1$s"
 PLG_DEBUG_ROWS_RETURNED_BY_QUERY="Rows returned: %s"
 PLG_DEBUG_SELECT_QUERIES="SELECT Tables:"
 PLG_DEBUG_SESSION="Session"
@@ -74,5 +78,3 @@ PLG_DEBUG_WARNING_NO_INDEX="NO INDEX KEY COULD BE USED"
 PLG_DEBUG_WARNING_NO_INDEX_DESC="This table probably has a missing index on WHERE equalities and/or JOIN ON column(s) or is written in a way that no index can be used, causing a time-consuming full table scan."
 PLG_DEBUG_WARNING_USING_FILESORT="Using filesort"
 PLG_DEBUG_WARNING_USING_FILESORT_DESC="This table probably has a missing index on WHERE/ON equality column(s) ending by the ORDER BY column(s) or is written in a way that no index can be used, causing a time-consuming filesort."
-PLG_DEBUG_XML_DESCRIPTION="This plugin provides a variety of system information as well as help for the creation of translation files."
-PLG_SYSTEM_DEBUG="System - Debug"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants