-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Deprecate debug plugin strings #40469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the debug plugin was refactored for j4 using phpdugbar a large number of strings were remaining that are simply not used. Basically only the strings in the plugin settings are used. The plugin itself is only in english and does not use translatabvle strings. This PR deprecates all 45 unused strings so that they can be removed in 5.0 and TT have less work to do
1 task
Deprecations should always go into the next minor release. Can you rebase the pr to 4.4? |
rebased |
Thanks! |
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 4, 2023
* Новое в Joomla 4.4.0 Alpha 4 joomla/joomla-cms#40071 + joomla/joomla-cms#40259 - (вероятно, ошибка при обновлении ветки автора) joomla/joomla-cms#40466 + joomla/joomla-cms#40469 + joomla/joomla-cms#40493 + joomla/joomla-cms#40510 + joomla/joomla-cms#40534 + joomla/joomla-cms#40533 + joomla/joomla-cms#40565 + joomla/joomla-cms#41024 + joomla/joomla-cms#40774 + joomla/joomla-cms#41099 + joomla/joomla-cms#41379 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the debug plugin was refactored for j4 using phpdugbar a large number of strings were remaining that are simply not used. Basically only the strings in the plugin settings are used. The plugin itself is only in english and does not use translatabvle strings.
This PR deprecates all 45 unused strings so that they can be removed in 5.0 and TT have less work to do
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed