Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Deprecate debug plugin strings #40469

Merged
merged 3 commits into from
May 2, 2023

Conversation

brianteeman
Copy link
Contributor

When the debug plugin was refactored for j4 using phpdugbar a large number of strings were remaining that are simply not used. Basically only the strings in the plugin settings are used. The plugin itself is only in english and does not use translatabvle strings.

This PR deprecates all 45 unused strings so that they can be removed in 5.0 and TT have less work to do

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

When the debug plugin was refactored for j4 using phpdugbar a large number of strings were remaining that are simply not used. Basically only the strings in the plugin settings are used. The plugin itself is only in english and does not use translatabvle strings.

This PR deprecates all 45 unused strings so that they can be removed in 5.0 and TT have less work to do
@laoneo
Copy link
Member

laoneo commented Apr 24, 2023

Deprecations should always go into the next minor release. Can you rebase the pr to 4.4?

@brianteeman brianteeman changed the title [4.3] Deprecate debug plugin strings [4.4] Deprecate debug plugin strings Apr 24, 2023
@brianteeman brianteeman changed the base branch from 4.3-dev to 4.4-dev April 24, 2023 15:59
@brianteeman
Copy link
Contributor Author

rebased

@laoneo laoneo merged commit 800be1e into joomla:4.4-dev May 2, 2023
@laoneo
Copy link
Member

laoneo commented May 2, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 4.4.0 milestone May 2, 2023
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants