Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phony 2.2.3 breaks test #51

Closed
espen opened this issue Mar 6, 2014 · 1 comment
Closed

Phony 2.2.3 breaks test #51

espen opened this issue Mar 6, 2014 · 1 comment

Comments

@espen
Copy link
Contributor

espen commented Mar 6, 2014

Failures:

  1. PhonyRails PhonyRails#normalize_number should handle some edge cases
    Failure/Error: PhonyRails.normalize_number('0323-2269497', :country_code => 'BE').should eql('3232269497')
   expected: "3232269497"
        got: "323232269497"

   (compared using eql?)
 # ./spec/lib/phony_rails_spec.rb:151:in `block (3 levels) in <top (required)>'
@bry4n
Copy link

bry4n commented May 8, 2014

Same here.

the value was 1-123-123-1234, it should expect +1 123 123 1234 as formatted value.

   Failure/Error: telephone_number.to_s.should == "+1 123 123 1234 ext: 1234"
       expected: "+1 123 123 1234 ext: 1234"
            got: "+1 231 231 234 ext: 1234" (using ==)

@joost joost closed this as completed in fb5b4a0 Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants