Phone extension support

[bourgeois]

I was wondering if phone extensions are currently supported ?

When I try to enter a phone number, followed by a comma and a phone extension, I get a validation error.

Thanks !

[joost]

Currently unsupported. Pull requests welcome :)

[GolfyMcG]

@joost how did you end up resolving this? I'm curious if you found something that could be turned into a PR or if you did what I'm sorting of thinking of - a separate attribute for extensions to be displayed alongside them.

Edit: Meant to say @bourgeois

[GolfyMcG]

Also, if anyone has any suggestions as to how this could be implemented, I'd be happy to give it a shot.

[jmera]

After encountering the same problem as @bourgeois, here is my suggestion:

During normalization, don't strip the first 'x' character if it exists. Any numeric characters that follow are considered the extension. If no numeric characters follow, strip the x—there is no extension.

EDIT
You could also let the user specify the "extension delimiting" string or an array of "extension delimiting" strings. It doesn't necessarily have to be 'x'. Something like:
phony_normalize :phone_number, default_country_code: 'US', extension_delimiter: 'ext'
or
phony_normalize :phone_number, default_country_code: 'US', extension_delimiter: %w(ext ext. x)

[joost]

Pull request welcome for this. I'm not familiar with 'extensions'.. Sounds logical to 'strip' everything after a "," or a "x".

[joost]

Closing, please reopen when with a pull request.