Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read message value directly from options #141

Merged
merged 1 commit into from May 1, 2016

Commits on Apr 28, 2016

  1. Read message value directly from options

    **Why**:
    With the changes in PR joost#139, specifying a symbolized value for the
    `message` option would cause that method to be called on the Model
    object. If that method didn't exist, it resulted in a `NoMethodError`
    exception. If that method did exist in the Model, and also as an i18n
    key, then the Model method was used, as opposed to the i18n key.
    
    The `message` option is meant to either be a String, or a symbol
    corresponding to an i18n key. Therefore, it should be read directly
    from `options[:message]` and not sent for further processing by the
    `options_value` method.
    
    **How**:
    - Revert the `error_message` method back to its value prior to PR joost#139,
    so that it uses `options[:message]`
    - Add 3 new specs to cover these scenarios
    monfresh committed Apr 28, 2016
    Configuration menu
    Copy the full SHA
    d3b9f10 View commit details
    Browse the repository at this point in the history