Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute to maintained fork #1

Closed
jschwartzenberg opened this issue Sep 5, 2020 · 2 comments
Closed

Contribute to maintained fork #1

jschwartzenberg opened this issue Sep 5, 2020 · 2 comments

Comments

@jschwartzenberg
Copy link

Hi @jordidg! Did you consider rebasing this and creating a PR against https://github.com/versat/cntlm which is still maintained? IPv6 support would be really great!
@jschwartzenberg
Copy link
Author

Just to let you know, I've created a PR based on your work. feature-wise it's working quite well both IPv4 and IPv6 are working in parallel with a few small changes. I hope to finish it off soon and get it included with the main branch.
versat/cntlm#8

@jordidg
Copy link
Owner

jordidg commented Oct 7, 2020

Hi @jschwartzenberg, thanks for the work to include it upstream.
I'm no longer using cntlm, but I'm glad to know my patches were useful to somebody.

@jordidg jordidg closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordidg @jschwartzenberg