Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Support ILogger fake #561

Closed

Conversation

AndreasVolkmann
Copy link

When using ILogger in plugins, the context would throw PullRequestException: The specified service type is not supported.

This PR adds support for fake loggers.

Had to upgrade the core deps, since ILogger wasn't available.

Let me know if you want any changes.

@jordimontana82
Copy link
Owner

Thanks for this PR @AndreasVolkmann !

Is this interface available only for Microsoft.CrmSdk.CoreAssemblies version >= 9.0.2.28 onwards?

@AndreasVolkmann
Copy link
Author

@jordimontana82 Yes, I chose the lowest version where the interface became available.

@BetimBeja
Copy link
Contributor

@k-babych-ua
Copy link

It's available in public now. This PR would help a lot.

@jordimontana82
Copy link
Owner

Looking to merge pull requests like this one soon...

@jordimontana82
Copy link
Owner

recheck

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 3 committers have signed the CLA.
@BetimBeja
@andreas Volkmann
@AndreasVolkmann
Andreas Volkmann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@jordimontana82
Copy link
Owner

Hi @AndreasVolkmann ! I'm looking at merging this PR soon. If you could please agree to the CLA it would be easier for us to also use the contribution in v2.x and v3.x versions which are on a different license. Thanks a mill!

@jordimontana82
Copy link
Owner

Hi @AndreasVolkmann , it seems ILogger was actually added into 9.0.2.27 of coreasemblies as opposed to 9.0.2.28 so I used that one in v2.x. I'll merge all the PRs with v2-ready into v1 too once they made it to both versions.

@strwase
Copy link

strwase commented May 6, 2022

Any update on when we can expect this release?

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
@AndreasVolkmann AndreasVolkmann deleted the ilogger-support branch May 6, 2022 15:09
@jordimontana82
Copy link
Owner

jordimontana82 commented May 6, 2022

@strwase This functionality as well as many other new stuff has been merged into v2.1.0 already. We'll bring these to 3.1.0 and then, we'll merge this PR, eventually. You might want to try these later versions cause it's where the focus is at right now.

https://dynamicsvalue.github.io/fake-xrm-easy-docs/releases/2x/2.1.0/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants