-
Notifications
You must be signed in to change notification settings - Fork 180
Support ILogger fake #561
Support ILogger fake #561
Conversation
Thanks for this PR @AndreasVolkmann ! Is this interface available only for Microsoft.CrmSdk.CoreAssemblies version >= 9.0.2.28 onwards? |
@jordimontana82 Yes, I chose the lowest version where the interface became available. |
This is the ILogger interface which is not in Public Preview yet 😄 |
It's available in public now. This PR would help a lot. |
Improved Fake ILogger behaviour
Looking to merge pull requests like this one soon... |
recheck |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 3 committers have signed the CLA. |
Hi @AndreasVolkmann ! I'm looking at merging this PR soon. If you could please agree to the CLA it would be easier for us to also use the contribution in v2.x and v3.x versions which are on a different license. Thanks a mill! |
Hi @AndreasVolkmann , it seems ILogger was actually added into 9.0.2.27 of coreasemblies as opposed to 9.0.2.28 so I used that one in v2.x. I'll merge all the PRs with v2-ready into v1 too once they made it to both versions. |
Any update on when we can expect this release? |
@strwase This functionality as well as many other new stuff has been merged into v2.1.0 already. We'll bring these to 3.1.0 and then, we'll merge this PR, eventually. You might want to try these later versions cause it's where the focus is at right now. https://dynamicsvalue.github.io/fake-xrm-easy-docs/releases/2x/2.1.0/ |
When using
ILogger
in plugins, the context would throwPullRequestException: The specified service type is not supported
.This PR adds support for fake loggers.
Had to upgrade the core deps, since
ILogger
wasn't available.Let me know if you want any changes.