Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still not working with Elvui #29

Open
BuildMoreWalls opened this issue Jul 24, 2019 · 4 comments
Open

Still not working with Elvui #29

BuildMoreWalls opened this issue Jul 24, 2019 · 4 comments

Comments

@BuildMoreWalls
Copy link

BuildMoreWalls commented Jul 24, 2019

Hello @jordonwow

Your add-on is just to good to be true !
It supposed to be fully compatible with Elvui according to your curseforge page; long story short : it ain't working for me nor either of my friends who tried it.
I've tried with Elvui's raid and unit frames and Blizzard's ones, as long as Elvui is loaded your add-on does not work.

https://imgur.com/ffrnRTG

I hope you can fix it.
Live long and prosper.

@BuildMoreWalls
Copy link
Author

Anyone's here?

@TheSumm
Copy link

TheSumm commented Jan 15, 2020

I am using ElvUI but have the ElvUI player frame disabled and use the default player frame instead.
It seems that BigDebuffs will hook to the ElvUI anchor regardless of it being disabled because ElvUI still registers it and BigDebuffs checks ElvUI frames first.
So unless I set Anchor to Manual in the unit frames settings, BigDebuffs will not show at all.

I am currently experimenting with a potential fix.
I have replaced this line with if anchor and anchor:IsVisible() then.
This should skip the disabled ElvUI frames and move to the blizzard frames successfully.
I am not sure about the side effects this change may have with other addons. Maybe @jordonwow has some input on this.

@kovaru
Copy link

kovaru commented Jan 21, 2020

I am currently experimenting with a potential fix.
I have replaced this line with if anchor and anchor:IsVisible() then.
This should skip the disabled ElvUI frames and move to the blizzard frames successfully.
I am not sure about the side effects this change may have with other addons. Maybe @jordonwow has some input on this.

Nice work. Initial tests show BigDebuffs working with ElvUI after swapping in the line you wrote. Please keep us posted on any updates and thank you for your effort.

@HoszeQ
Copy link

HoszeQ commented Dec 7, 2020

You need to replace this line with " if anchor and anchor:IsVisible() then " and then it will works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants