-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidMakers breaks sessions have "service" type causing them to be displayed in white even in dark mode #1313
Comments
ah, thanks....that does look pretty ugly all right :) |
If service sessions are white (on light mode) what would be the correct color in dark mode ? |
I"m not sure tbh what best colour would be to use there (am definitely not a designer :) ) ....maybe one of standard ones with some change in alpha or perhaps tonalElevation as we do with |
Yeah, that definitely looks better....also btw just noticed we show bookmark option for those which I guess we shouldn't! |
Ok, so for breaks and services we shouldn't have the bookmark option ? From what I see, the bookmark option is visible because the breaks for Android Makers have the service type. If the type was correct, the option wouldn't be visible.
|
Sorry, I'm also definitely not a designer 😅 - but on the proposed screenshots above, it looks like the break/service sessions are actually highlighted and have an importance higher than the other sessions whereas, arguably, it's the opposite 😅 They should probably have the same color as the background instead. |
Ok 😄, I'm going to try to find a dimmer color (background on dark theme gives me a full black list 😅 ) |
I'm not super familiar with options here but wondering what |
I will look into it 👍 |
That definitely looks better. @BoD what you think? |
You can check this pull request for the code I wrote : #1314 |
That's merged now |
When displaying Android Makers 2024 sessions, breaks are displayed in white even on dark mode. That's because they have the type "service" and not "break".
Also, I guess this code is going to be updated to match the theme.
The text was updated successfully, but these errors were encountered: