[receiver/redis] Seconds as unit for redis.cmd.latency metric. (open-…

…telemetry#26686) Changed unit for `redis.cmd.latency` metric from microseconds to seconds. open-telemetry#6942 Co-authored-by: Alex Boten <aboten@lightstep.com>
jorgeancal · Sep 18, 2023 · 7c96f61 · 7c96f61
1 parent b4f997d
commit 7c96f61
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/receiver/redisreceiver/documentation.md b/receiver/redisreceiver/documentation.md
@@ -298,7 +298,7 @@ Command execution latency
 
 | Unit | Metric Type | Value Type |
 | ---- | ----------- | ---------- |
-| us | Gauge | Double |
+| s | Gauge | Double |
 
 #### Attributes
 

diff --git a/receiver/redisreceiver/internal/metadata/generated_metrics.go b/receiver/redisreceiver/internal/metadata/generated_metrics.go
diff --git a/receiver/redisreceiver/internal/metadata/generated_metrics_test.go b/receiver/redisreceiver/internal/metadata/generated_metrics_test.go
diff --git a/receiver/redisreceiver/metadata.yaml b/receiver/redisreceiver/metadata.yaml
@@ -94,7 +94,7 @@ metrics:
   redis.cmd.latency:
     enabled: false
     description: Command execution latency
-    unit: us
+    unit: s
     gauge:
       value_type: double
     attributes: [cmd, percentile]

diff --git a/receiver/redisreceiver/redis_scraper.go b/receiver/redisreceiver/redis_scraper.go
@@ -212,14 +212,16 @@ func (rs *redisScraper) recordCmdStatsMetrics(ts pcommon.Timestamp, cmd, val str
 
 // recordCmdLatencyMetrics record latency metrics of a particular Redis command.
 // 'cmd' is the Redis command, 'val' is the values string (e.g. "p50=1.003,p99=1.003,p99.9=1.003).
+// Latency values in the values string are expressed in microseconds.
 func (rs *redisScraper) recordCmdLatencyMetrics(ts pcommon.Timestamp, cmd, val string) {
 	latencies, err := parseLatencyStats(val)
 	if err != nil {
 		return
 	}
 
-	for percentile, latency := range latencies {
+	for percentile, usecs := range latencies {
 		if percentileAttr, ok := metadata.MapAttributePercentile[percentile]; ok {
+			latency := usecs / 1e6 // metric is in seconds
 			rs.mb.RecordRedisCmdLatencyDataPoint(ts, latency, cmd, percentileAttr)
 		}
 	}