Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/redis] Seconds as unit for redis.cmd.latency metric. #26686

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[receiver/redis] Seconds as unit for redis.cmd.latency metric. #26686

merged 2 commits into from
Sep 14, 2023

Conversation

bjandras
Copy link
Contributor

Description: Changed unit for redis.cmd.latency metric from microseconds to seconds.

Link to tracking Issue: #6942

@github-actions github-actions bot added the receiver/redis Redis related issues label Sep 14, 2023
@bjandras
Copy link
Contributor Author

This is a folow-up to PR #26569, so it can skip the changelog.

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 14, 2023
@bjandras bjandras marked this pull request as ready for review September 14, 2023 15:44
@bjandras bjandras requested a review from a team as a code owner September 14, 2023 15:44
codeboten
codeboten reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming the latency metrics have not been published in a release yet? Otherwise this would be a breaking change

@bjandras
Copy link
Contributor Author

@codeboten Not to my knowledge. The PR that introduced latency metrics has been merged recently. This PR is a response to #26569 (comment).

@crobert-1
Copy link
Member

@codeboten Not to my knowledge. The PR that introduced latency metrics has been merged recently. This PR is a response to #26569 (comment).

I confirmed new metrics were merged yesterday, and have not been released yet.

codeboten
codeboten approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming @bjandras @crobert-1

@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Sep 14, 2023
@codeboten codeboten merged commit e6c544c into open-telemetry:main Sep 14, 2023
96 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 14, 2023
@bjandras bjandras deleted the redisreceiver_cmd_latency_secs branch September 15, 2023 15:41
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Sep 18, 2023
@bjandras @jorgeancal
[receiver/redis] Seconds as unit for redis.cmd.latency metric. (open-…
7c96f61 
…telemetry#26686)

Changed unit for `redis.cmd.latency` metric from
microseconds to seconds.

open-telemetry#6942

Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@hughesjj hughesjj Awaiting requested review from hughesjj

Assignees

@dmitryax dmitryax

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/redis Redis related issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bjandras @crobert-1 @codeboten @atoulme @dmitryax