Revisit redis receiver metrics #6942

dmitryax · 2021-12-23T06:53:33Z

The following issues found with the redis receiver metrics:

Many metrics miss unit field.
Some metrics can be combined with an additional attribute, e.g. different metrics for memory -> one metrics + "state" attribute.
Start timestamp is inconsistent between sum and gauge metrics.
CPU metrics reported inconsistently, only 3 of 8 redis metrics reported:
- used_cpu_sys -> redis.cpu.time{state=sys}
- used_cpu_user -> redis.cpu.time{state=user}
- used_cpu_sys_children -> redis.cpu.time{state=children}
- used_cpu_user_children is skipped
- used_cpu_sys_main_thread is skipped
- used_cpu_user_main_thread is skipped
More than half of the redis metrics are not collected at all, they can be added as optional (disabled by default) metrics once [receiver/redis] Apply new mdatagen metrics builder #6938 is merged.

github-actions · 2022-11-14T03:49:11Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @pmcollins @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions · 2023-01-16T03:30:21Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @pmcollins @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions · 2023-03-20T03:30:17Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions · 2023-05-22T03:31:18Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions · 2023-07-21T05:18:42Z

This issue has been closed as inactive because it has been stale for 120 days with no activity.

crobert-1 · 2023-09-06T18:02:41Z

@bjandras has volunteered to take this.

bjandras · 2023-09-06T18:57:10Z

Missing CPU metrics addressed in #14943.

bjandras · 2023-09-06T18:58:45Z

Missing metric units addressed in #23573.

**Description:** Added command latency metric to the redis receiver. **Link to tracking Issue:** #6942 **Testing:** Added tests for parsing `latencystats` section of redis info. **Documentation:** Metric documentation in metadata.yaml

Changed unit for `redis.cmd.latency` metric from microseconds to seconds. #6942 Co-authored-by: Alex Boten <aboten@lightstep.com>

**Description:** Added command latency metric to the redis receiver. **Link to tracking Issue:** open-telemetry#6942 **Testing:** Added tests for parsing `latencystats` section of redis info. **Documentation:** Metric documentation in metadata.yaml

…telemetry#26686) Changed unit for `redis.cmd.latency` metric from microseconds to seconds. open-telemetry#6942 Co-authored-by: Alex Boten <aboten@lightstep.com>

bjandras · 2023-09-27T21:18:01Z

Here's a breakdown of all available Redis metrics and their OTel counterparts (if implemented): https://docs.google.com/spreadsheets/d/1KRM5NuFnYxiW1EJ00wt-NF1LhrIbuWjn-iC-lAOrfQg/edit?usp=sharing. We can use it to select which metric to collect.

github-actions · 2023-11-27T03:30:24Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

hughesjj · 2023-11-27T22:23:41Z

@bjandras Hey, how was that output generated btw? Doing some auditing on my end, would like to have a reproducible way (even if runbook-esque) to validate ongoing coverage improvement.

**Description:** Adds missing metrics for `slave_repl_offset` and adds an integration test to configure a cluster to test such **Link to tracking Issue:** [`6942`](#6942) **Testing:** `cd receiver/redisreceiver && make mod-integration-test` **Documentation:** (autogenerated from mdatagen)

github-actions · 2024-01-29T03:29:50Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

**Description:** Adds missing metrics for `slave_repl_offset` and adds an integration test to configure a cluster to test such **Link to tracking Issue:** [`6942`](open-telemetry#6942) **Testing:** `cd receiver/redisreceiver && make mod-integration-test` **Documentation:** (autogenerated from mdatagen)

github-actions · 2024-04-01T03:29:31Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

dmitryax added the bug Something isn't working label Dec 23, 2021

dmitryax mentioned this issue Dec 23, 2021

[receiver/redis] Set start timestamp uniformly for gauge and sum metrics #6941

Merged

djaglowski mentioned this issue Jan 19, 2022

[receiver/zookeeper] Revisit metrics #7277

Closed

2 tasks

dmitryax added the receiver/redis Redis related issues label Sep 14, 2022

github-actions bot added the Stale label Nov 14, 2022

dmitryax added help wanted Extra attention is needed and removed Stale labels Nov 14, 2022

github-actions bot added the Stale label Jan 16, 2023

fatsheep9146 removed the Stale label Jan 16, 2023

github-actions bot added the Stale label Mar 20, 2023

dmitryax removed the Stale label Mar 23, 2023

github-actions bot added the Stale label May 22, 2023

github-actions bot added the closed as inactive label Jul 21, 2023

github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2023

dmitryax removed Stale closed as inactive labels Jul 21, 2023

dmitryax reopened this Jul 21, 2023

crobert-1 assigned crobert-1 and bjandras and unassigned crobert-1 Sep 6, 2023

bjandras mentioned this issue Sep 11, 2023

[receiver/redis] Command latency metrics. #26569

Merged

bjandras mentioned this issue Sep 14, 2023

[receiver/redis] Seconds as unit for redis.cmd.latency metric. #26686

Merged

codeboten pushed a commit that referenced this issue Sep 14, 2023

[receiver/redis] Seconds as unit for redis.cmd.latency metric. (#26686)

e6c544c

Changed unit for `redis.cmd.latency` metric from microseconds to seconds. #6942 Co-authored-by: Alex Boten <aboten@lightstep.com>

github-actions bot added the Stale label Nov 27, 2023

github-actions bot removed the Stale label Nov 28, 2023

hughesjj mentioned this issue Dec 21, 2023

Redis replica offset #29565

Merged

github-actions bot added the Stale label Jan 29, 2024

crobert-1 removed the Stale label Jan 29, 2024

github-actions bot added the Stale label Apr 1, 2024

atoulme removed the Stale label Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revisit redis receiver metrics #6942

Revisit redis receiver metrics #6942

dmitryax commented Dec 23, 2021 •

edited

github-actions bot commented Nov 14, 2022

github-actions bot commented Jan 16, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented May 22, 2023

github-actions bot commented Jul 21, 2023

crobert-1 commented Sep 6, 2023

bjandras commented Sep 6, 2023

bjandras commented Sep 6, 2023

bjandras commented Sep 27, 2023

github-actions bot commented Nov 27, 2023

hughesjj commented Nov 27, 2023

github-actions bot commented Jan 29, 2024

github-actions bot commented Apr 1, 2024

Revisit redis receiver metrics #6942

Revisit redis receiver metrics #6942

Comments

dmitryax commented Dec 23, 2021 • edited

github-actions bot commented Nov 14, 2022

github-actions bot commented Jan 16, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented May 22, 2023

github-actions bot commented Jul 21, 2023

crobert-1 commented Sep 6, 2023

bjandras commented Sep 6, 2023

bjandras commented Sep 6, 2023

bjandras commented Sep 27, 2023

github-actions bot commented Nov 27, 2023

hughesjj commented Nov 27, 2023

github-actions bot commented Jan 29, 2024

github-actions bot commented Apr 1, 2024

dmitryax commented Dec 23, 2021 •

edited