Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Investigate how to add support for timezones in timestamp #23

Closed
jorgecarleitao opened this issue Mar 24, 2021 · 4 comments · Fixed by #417
Closed

Investigate how to add support for timezones in timestamp #23

jorgecarleitao opened this issue Mar 24, 2021 · 4 comments · Fixed by #417
Assignees
Labels
enhancement An improvement to an existing feature help wanted Extra attention is needed

Comments

@jorgecarleitao
Copy link
Owner

We currently support timezones at logical level, via Timestamp(_, tz), but have no mechanism to perform operations with them, The goal is to investigate how to add support for them. This will likely require depending on chrono-tz.

A simple concrete goal here is to add support to cast from and to Timestamp(_, str) and Timestamp(_, None).

A question here is how we represent these things: it seems that in chrono-tz, timezones are static types (i.e. struct), while timezones in Arrow are dynamic (i.e. str).

@jorgecarleitao jorgecarleitao added enhancement An improvement to an existing feature help wanted Extra attention is needed labels Mar 24, 2021
@jorgecarleitao jorgecarleitao self-assigned this Apr 23, 2021
@elferherrera
Copy link
Contributor

What happened to this one? Did you managed to get timezones working?

@jorgecarleitao
Copy link
Owner Author

There has been some discussions over the mailing list on how timezones should be treated, so I have not touched this. It seems that they have settled, though.

@elferherrera
Copy link
Contributor

I didnt follow the mailing list, sorry. What was the final solution at the end?

@jorgecarleitao
Copy link
Owner Author

@elferherrera , being done in #376 . Took a bit to understand what was that about. It would be great if you could take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants