-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emacs 27.1 obsoleted tls.el #377
Comments
Closed
This was referenced Sep 28, 2020
Thaodan
added a commit
to Thaodan/doomemacs
that referenced
this issue
Jul 23, 2024
tls.el is obsolete in Emacs 26.1 or later, it's no longer used in Circe. The workaround is no longer required. See also: emacs-circe/circe#340 emacs-circe/circe#377 doomemacs#1862
hlissner
added a commit
to doomemacs/doomemacs
that referenced
this issue
Jul 26, 2024
Circe dropped its dependency on tls.el for gnutls. Ref: emacs-circe/circe#377 Ref: emacs-circe/circe#340 Ref: emacs-circe/circe@a71d55d6b87f Ref: #1862 Close: #7959 Co-authored-by: Thaodan <Thaodan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've upgraded and got a warning about tls.el being obsoleted. No rush of fixing this one, but in a future release it will be gone. This shouldn't be too hard to fix, things I've found so far:
tls-end-of-info
needs to be vendored. I remember a bug report about it where the regexp has been adjusted and should take a closer look whether the suggested or the most current regexp work better.tls-program
seems analogous totls-connection-command
, but omits OpenSSLss_client
which caused numerous issues in the past and should most likely not be used. There's at least one bug report about it and it might need adjustment, too.tls-process-connection-type
andtls-success
need to be vendored.(require 'tls)
should be dropped and a changelog note about lack ofs_client
support made.See also:
A more drastic solution would be to use built-in TLS support as suggested in the last link, at the cost of Emacs possibly hanging when reconnecting (an issue not present with the subprocess solution).
The text was updated successfully, but these errors were encountered: