Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking to all typ_apply functions #14

Open
joschu opened this issue Aug 28, 2015 · 2 comments
Open

Add type checking to all typ_apply functions #14

joschu opened this issue Aug 28, 2015 · 2 comments
Labels
Milestone

Comments

@joschu
Copy link
Owner

joschu commented Aug 28, 2015

The functions Op.typ_apply should check the input types and throw human-understandable exceptions when necessary. E.g., Mul22 needs to make sure that both of its inputs have ndim=2 and float or complex types.

@joschu joschu added this to the 0.2 milestone Sep 1, 2015
@joschu joschu added the bug label Sep 1, 2015
@siddharth-agrawal
Copy link

I would like to work on this. On doing a simple 'grep', I found that typ_apply is not used widely within the library. How can I test the changes, to make sure that I don't break anything? Also, should I make a list of the ops for which changes are required?

@joschu
Copy link
Owner Author

joschu commented Sep 7, 2015

Hi Siddarth, you can run the unit tests to (hopefully) verify that you didn't break anything. typ_apply isn't explicitly called very often but it's called whenever a new node is created using Result(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants