Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference from https://github.com/josdejong/jsoneditor? #71

Closed
zehawki opened this issue Apr 28, 2022 · 5 comments
Closed

Difference from https://github.com/josdejong/jsoneditor? #71

zehawki opened this issue Apr 28, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@zehawki
Copy link

zehawki commented Apr 28, 2022

Thank you for this brilliant library. Ive been a long time user of jsoneditoronline.org (its a pinned tab since I use it all the time 😁).

Would be good to have some documentation as to how this package is different from your previous lib (https://github.com/josdejong/jsoneditor) and also why you decided to create another.

I also see that the demo for the earlier is pointing to http://jsoneditoronline.org/ while the latter is pointing to https://jsoneditoronline.org/, but both seem to be running off svelte-jsoneditor as per the changelog.

@zehawki
Copy link
Author

zehawki commented Apr 28, 2022

Ok I see this josdejong/jsoneditor#1223

@josdejong
Copy link
Owner

Thanks Amit, glad to hear you like it!

Yes, in josdejong/jsoneditor#1223 a lot of the thoughts behind this are discussed, but it is a lengthy discussion. I do like your idea though, for example to write a section in the readme of svelte-jsoneditor about this. It can help having a bit of context.

@josdejong josdejong added the documentation Improvements or additions to documentation label Apr 28, 2022
@josdejong
Copy link
Owner

@zehawki I've written a section explaining the differences: https://github.com/josdejong/svelte-jsoneditor#differences-between-josdejongsvelte-jsoneditor-and-josdejongjsoneditor

Does this clarify things?

@zehawki
Copy link
Author

zehawki commented May 2, 2022

Its quite perfect, thank you. Maybe add a row on bundle size & dependencies if you like?

@josdejong
Copy link
Owner

Ok 👍

Hmm. The bundle size and dependencies are tricky: they will probably change over time, I prefer not to list them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants