Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Option for Items with 800+ Item Power Only #53

Closed
meeks726 opened this issue Sep 3, 2023 · 6 comments
Closed

[Suggestion] Option for Items with 800+ Item Power Only #53

meeks726 opened this issue Sep 3, 2023 · 6 comments

Comments

@meeks726
Copy link

meeks726 commented Sep 3, 2023

I think it would be great to have an option to only scan items with Item Power of 800 or greater. So if an item is less than 800 Item Power then don't do scan for any affixes etc

@imm0r
Copy link

imm0r commented Sep 4, 2023

Absolutly i have thought about requesting this too but then moved my request until v2 will hit the light ;)

@imm0r
Copy link

imm0r commented Sep 5, 2023

searching for this image should pretty much do the job... only difficulty should be to get the correct position to look for the image for every possible resolutionl.

@josdemmers
Copy link
Owner

josdemmers commented Sep 5, 2023

Idea is good, now we need a reliable way to implement it.
Upgrading items changes the location as well, see examples below. Also just the 8 wont be enough. There is an 8 in 800, 80, and 8 as well.
image
image

Or we could just ignore equiped items and only let the filter work for dropped items.

@meeks726
Copy link
Author

meeks726 commented Sep 5, 2023

I think in this case and only specially for this part of the check, converting the 'Item Power' section in the tooltip into a string might be helpful and have a statement to check if the string value is greater than 800. But then again, this points back to what you said about converting to strings in the other thread about having multiple languages etc

@meeks726
Copy link
Author

meeks726 commented Sep 5, 2023

Could maybe do the same checks as finding the affix locations by using an image of the "Item Power" without the number. Then within that location/section/row, search for the number, convert that number to a string, then check whether that string is greater than 800

@josdemmers
Copy link
Owner

Now that the app uses OCR is was easier to implement.
Item power filter will be available in the v3.2.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants