Fix all remaining self-check errors #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
15 lines, but we get a failure in property based tests :| |
erszcz
force-pushed
the
fix-more-self-check-errors
branch
from
431c1ac
to
4bb2da4
Compare
erszcz
force-pushed
the
fix-more-self-check-errors
branch
2 times, most recently
from
30f7c8f
to
da2a4fd
Compare
erszcz
changed the title
|
Gradualizer can now self-check with no warnings emitted! 🎉 |
erszcz
changed the title
zuiderkwast
reviewed
Mar 15, 2023
| @@ -90,7 +90,7 @@ bin/gradualizer: $(beams) ebin/gradualizer.app | |||
|
|
|||
| .PHONY: gradualize | |||
| gradualize: escript | |||
| bin/gradualizer --infer --solve_constraints --specs_override_dir priv/extra_specs/ \ | |||
| @bin/gradualizer --infer --solve_constraints --specs_override_dir priv/extra_specs/ \ | |||
There was a problem hiding this comment.
You don't want the user to see which command we're running?
There was a problem hiding this comment.
It's connected with how we count lines in the CI self-check assessment (see changes to .github/workflows/self-check.yml in this PR). We cannot rely on the status code, because we ignore some trivial errors with grep -v and the status code always reflects failure. We check the number of error lines instead. If we print the command, we have to assume that exactly 2 lines means "no errors", which is a bit strange. If we do not print the command, 0 error lines means "no errors", i.e. a success.
All in all, it's a detail. The user can still see the command in the Makefile.
…_pass/list_op_pass.erl
erszcz
force-pushed
the
fix-more-self-check-errors
branch
from
da2a4fd
to
3e31239
Compare
…should_pass/poly_should_pass.erl
|
Nice! |
erszcz
added a commit
to erszcz/erlang_ls
that referenced
this pull request
Jun 16, 2023
This version brings approx. 30 new PRs. The highlights are: - Improve map exhaustiveness checking [erlang-ls#524](josefs/Gradualizer#524) by @xxdavid - Fix all remaining self-check errors [erlang-ls#521](josefs/Gradualizer#521) by @erszcz - Fix intersection-typed function calls with union-typed arguments [erlang-ls#514](josefs/Gradualizer#514) by @erszcz - Experimental constraint solver [erlang-ls#450](josefs/Gradualizer#450) by @erszcz
erszcz
added a commit
to erszcz/erlang_ls
that referenced
this pull request
Jun 16, 2023
This version brings approx. 30 PRs. The highlights are: - Improve map exhaustiveness checking [erlang-ls#524](josefs/Gradualizer#524) by @xxdavid - Fix all remaining self-check errors [erlang-ls#521](josefs/Gradualizer#521) by @erszcz - Fix intersection-typed function calls with union-typed arguments [erlang-ls#514](josefs/Gradualizer#514) by @erszcz - Experimental constraint solver [erlang-ls#450](josefs/Gradualizer#450) by @erszcz
erszcz
added a commit
to erszcz/erlang_ls
that referenced
this pull request
Jun 16, 2023
This version brings approx. 30 PRs. The highlights are: - Improve map exhaustiveness checking [erlang-ls#524](josefs/Gradualizer#524) by @xxdavid - Fix all remaining self-check errors [erlang-ls#521](josefs/Gradualizer#521) by @erszcz - Fix intersection-typed function calls with union-typed arguments [erlang-ls#514](josefs/Gradualizer#514) by @erszcz - Experimental constraint solver [erlang-ls#450](josefs/Gradualizer#450) by @erszcz
robertoaloi
pushed a commit
to erlang-ls/erlang_ls
that referenced
this pull request
Jun 17, 2023
This version brings approx. 30 PRs. The highlights are: - Improve map exhaustiveness checking [#524](josefs/Gradualizer#524) by @xxdavid - Fix all remaining self-check errors [#521](josefs/Gradualizer#521) by @erszcz - Fix intersection-typed function calls with union-typed arguments [#514](josefs/Gradualizer#514) by @erszcz - Experimental constraint solver [#450](josefs/Gradualizer#450) by @erszcz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Down to 37 lines so far 🎉