Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arbitrary grid lines #35

Closed
GoogleCodeExporter opened this issue Apr 14, 2016 · 4 comments
Closed

Support for arbitrary grid lines #35

GoogleCodeExporter opened this issue Apr 14, 2016 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Through the use of flot for some internal projects we've needed to show
'markers' on graphs, to indicate trends toward a value, etc.

I've made the change to support this in the source, changed the
'setting-options' example to use it and updated the documentation with a
quick note on it's use.

Please see the attached diff for inclusion/consideration.

I'm no 'canvas' expert so please feel completely free to alter the code in
any way that might be necessary.

Take care,
    Ryan

ps. Thanks for flot! It's awesome :)

Original issue reported on code.google.com by ryan.fun...@gmail.com on 17 May 2008 at 12:55

Attachments:

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

I applied your patch and checked it out. The patch itself is great (you even 
added
docs, thanks!). But I'm not going to take it. I think the benefit of 
introducing a
new concept compared to e.g. simply adding another line data series to the 
chart is
too small.

I would rather either see support for plotting functions (I'm thinking along the
lines of { generator: f, samples: 100 }), then simply {generator: function f(x) 
{
return 0; }}, or support for excluding a data series when auto-computing the 
axis
ranges, along the lines of { data: [[-10000, 0], [10000, 0]], 
excludefromranges: true }.

Original comment by olau%iol...@gtempaccount.com on 8 Sep 2008 at 9:19

  • Changed state: WontFix
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Coming to think of it, support for plotting functions isn't going to help a 
lot, as
it is not going to solve the problem of drawing vertical lines in a 
straightforward
fashion.

I had another look, and I actually think my only real beef with this patch is 
the
name "marker". So I have reopened this bug. I'm not ready to apply it right now,
though. I think taking a callback to generate the list is worthwhile as with the
coloredAreas (which BTW have a lame name). Maybe it is possible to merge the two
concepts into one under a new name, line if you specify some parameters, area 
if you
specify more.

Original comment by olau%iol...@gtempaccount.com on 10 Sep 2008 at 3:59

  • Changed title: Support for arbitrary grid lines
  • Changed state: New

@GoogleCodeExporter
Copy link
Author

Support for lines is in SVN now as "markings", formerly coloredAreas.

Original comment by olau%iol...@gtempaccount.com on 22 Sep 2008 at 5:53

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant