Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Lines get rendered 1px too far left #8

Closed
GoogleCodeExporter opened this issue Apr 14, 2016 · 8 comments
Closed

Graph Lines get rendered 1px too far left #8

GoogleCodeExporter opened this issue Apr 14, 2016 · 8 comments

Comments

@GoogleCodeExporter
Copy link

If you look closely at any rendered graph, the lines start on the left
border not inside it.

Original issue reported on code.google.com by ja...@shaped.ca on 7 Dec 2007 at 1:25

@GoogleCodeExporter
Copy link
Author

Well spotted! It's because of an ugly hack I never removed completely fully. 
I've
done that now. The fix will be in the next release which I'm uploading now.

Original comment by olau%iol...@gtempaccount.com on 7 Dec 2007 at 3:05

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Sweeeeet. :)

Original comment by ja...@shaped.ca on 7 Dec 2007 at 3:56

@GoogleCodeExporter
Copy link
Author

Hi,

Your fix has not completely solved the problem, though obviously it has helped.

As you can see, it's still leaking past the border. Perhaps you can render the 
border
over top of the lines instead of vice versa.

http://shaped.ca/flot.jpg

As you can see though, your graph looks nice in my application. :)

Original comment by ja...@shaped.ca on 7 Dec 2007 at 4:08

@GoogleCodeExporter
Copy link
Author

The remainding overlap is on purpose, it's a stylistic artifact. :-)

Original comment by olau%iol...@gtempaccount.com on 7 Dec 2007 at 4:29

@GoogleCodeExporter
Copy link
Author

And your stylistic artifact takes away from the design of my interface.

Provide an option or fix it, or I will have to, no offense but that kind of a
response isn't acceptable for publicly released works. :(

Original comment by ja...@shaped.ca on 7 Dec 2007 at 10:17

@GoogleCodeExporter
Copy link
Author

If you can figure out how to avoid the overlap with everything still looking 
fine,
feel free to submit a patch.

I don't think drawing the grid outline on top of the graphs is a good solution,
because it means that we'd have to shuffle the code around to still have points 
on
top of the outline. So I suggest you take a look at the drawSeriesLines and the
embedded plotLine functions.

Original comment by olau%iol...@gtempaccount.com on 10 Dec 2007 at 11:38

@GoogleCodeExporter
Copy link
Author

I just changed the border to be like a CSS border. So the overlap is gone now.

Original comment by olau%iol...@gtempaccount.com on 13 Jan 2009 at 1:13

@GoogleCodeExporter
Copy link
Author

I'll check it out! Thanks for fixing this even though it's a 1+ year old bug!

Original comment by ja...@shaped.ca on 13 Jan 2009 at 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant